Skip to content

Kv Cache as mutable buffer #2595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

JacobSzwejbka
Copy link
Contributor

Summary: Big mish mash of changes to support kv cache as a mutable buffer see this stack D55219107 for the individual reviews

Reviewed By: mergennachin

Differential Revision: D55229223

Copy link

pytorch-bot bot commented Mar 22, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/2595

Note: Links to docs will display an error until the docs builds have been completed.

❌ 5 New Failures, 1 Unrelated Failure

As of commit c0b7ad3 with merge base ba920e4 (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 22, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D55229223

JacobSzwejbka added a commit to JacobSzwejbka/executorch-1 that referenced this pull request Mar 22, 2024
Summary:

Big mish mash of changes to support kv cache as a mutable buffer see this stack D55219107 for the individual reviews

Reviewed By: mergennachin

Differential Revision: D55229223
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D55229223

Summary:

Big mish mash of changes to support kv cache as a mutable buffer see this stack D55219107 for the individual reviews

Reviewed By: mergennachin

Differential Revision: D55229223
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D55229223

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 1d934f0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants