CMake Use python instead of python3 when in a (non-base) conda environment #2687
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/2687
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 1 Unrelated FailureAs of commit b8ad04d with merge base ccecd3a ( NEW FAILURE - The following job has failed:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
@GregoryComer has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
GregoryComer
force-pushed
the
conda-python-cmake-fix
branch
2 times, most recently
from
0c5f583 to
c25e31b
Compare
GregoryComer
force-pushed
the
conda-python-cmake-fix
branch
2 times, most recently
from
4dd3814 to
65c1b2a
Compare
|
@GregoryComer has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
1 similar comment
|
@GregoryComer has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
GregoryComer
force-pushed
the
conda-python-cmake-fix
branch
from
65c1b2a to
b8ad04d
Compare
|
@GregoryComer has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@GregoryComer merged this pull request in cf83964. |
|
@pytorchbot cherry-pick --onto release/0.2 -c fixnewfeature |
|
Trying again, since the bot seemed to have an issue which was fixed since yesterday. @pytorchbot cherry-pick --onto release/0.2 -c critical |
…nment (#2687) Summary: When building inside a conda environment (the recommended configuration), we should use 'python' instead of 'python3'. In some environments (mac), 'python3' may resolve to the incorrect python binary. This change maintains backwards compatibility for non-conda users by still defaulting to python3. Note that pytorch core appears to default to 'python', instead of 'python3', so we may want to look at doing so in the future. Bypassing unrelated lint (fix already in progress). bypass-github-export-checks bypass-github-executorch-ci-checks Pull Request resolved: #2687 Test Plan: On both Linux and Mac, I performed the following: Built in non-base conda environment, Checked build log to ensure it uses 'python'. Built in base conda environment. Checked build log to ensure it uses 'python3'. Built in non-conda environment. Checked build log to ensure it uses 'python3'. Reviewed By: mcr229 Differential Revision: D55370314 Pulled By: GregoryComer fbshipit-source-id: 281bafa78f6523d7c03b8a736134f18bd6cea45b (cherry picked from commit cf83964)
Cherry picking #2687The cherry pick PR is at #2745 and it is recommended to link a critical cherry pick PR with an issue Details for Dev Infra teamRaised by workflow job |
When building inside a conda environment (the recommended configuration), we should use 'python' instead of 'python3'. In some environments (mac), 'python3' may resolve to the incorrect python binary. This change maintains backwards compatibility for non-conda users by still defaulting to python3.
Note that pytorch core appears to default to 'python', instead of 'python3', so we may want to look at doing so in the future.
Test Plan:
On both Linux and Mac, I performed the following:
Built in non-base conda environment, Checked build log to ensure it uses 'python'.
Built in base conda environment. Checked build log to ensure it uses 'python3'.
Built in non-conda environment. Checked build log to ensure it uses 'python3'.