Skip to content

Add cherry pick script from PT #2716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Add cherry pick script from PT #2716

wants to merge 1 commit into from

Conversation

huydhn
Copy link
Contributor

@huydhn huydhn commented Mar 27, 2024

The copy from third_party/pytorch doesn't work because it points to PyTorch

@huydhn huydhn requested a review from guangy10 March 27, 2024 18:35
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Mar 27, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/2716

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 07818d4 with merge base d64fc74 (image):

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 27, 2024
@facebook-github-bot
Copy link
Contributor

@huydhn has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

guangy10
guangy10 reviewed Mar 27, 2024
View reviewed changes
.github/scripts/cherry_pick.py

from github_utils import gh_fetch_url, gh_post_pr_comment

from gitutils import get_git_remote_name, get_git_repo_dir, GitRepo
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't exist for ET

@facebook-github-bot
Copy link
Contributor

@huydhn has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@guangy10
Copy link
Contributor

@huydhn can you link a result of local/manual run? Just to ensure we are not spotting new issues after waiting for this one to be landed

@huydhn @facebook-github-bot
Add cherry pick script from PT (#2716)
07818d4 
Summary:
The copy from third_party/pytorch doesn't work because it points to PyTorch


Reviewed By: guangy10

Differential Revision: D55434703

Pulled By: huydhn
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D55434703

@facebook-github-bot
Copy link
Contributor

@huydhn merged this pull request in 25cc295.

@facebook-github-bot
Copy link
Contributor

This pull request has been reverted by 04d568d.

@huydhn huydhn mentioned this pull request Jun 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guangy10 guangy10 guangy10 approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged Reverted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@huydhn @facebook-github-bot @guangy10