refactor runner to fix bugs #2752
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/2752
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 1 Unrelated FailureAs of commit 88dcd2c with merge base a624345 ( NEW FAILURE - The following job has failed:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D55496044 |
JacobSzwejbka
added a commit
to JacobSzwejbka/executorch-1
that referenced
this pull request
Mar 28, 2024
Summary: Lots of bugs before with kv cache implementation of runner. Trying this out Differential Revision: D55496044
JacobSzwejbka
force-pushed
the
export-D55496044
branch
from
b82b583 to
4cfb59a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55496044 |
JacobSzwejbka
force-pushed
the
export-D55496044
branch
from
4cfb59a to
f77ffc8
Compare
JacobSzwejbka
added a commit
to JacobSzwejbka/executorch-1
that referenced
this pull request
Mar 28, 2024
Summary: Lots of bugs before with kv cache implementation of runner. Trying this out Differential Revision: D55496044
|
This pull request was exported from Phabricator. Differential Revision: D55496044 |
JacobSzwejbka
added a commit
to JacobSzwejbka/executorch-1
that referenced
this pull request
Mar 28, 2024
Summary: Lots of bugs before with kv cache implementation of runner. Trying this out Differential Revision: D55496044
JacobSzwejbka
force-pushed
the
export-D55496044
branch
from
f77ffc8 to
12177e5
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55496044 |
JacobSzwejbka
added a commit
to JacobSzwejbka/executorch-1
that referenced
this pull request
Mar 28, 2024
Summary: Lots of bugs before with kv cache implementation of runner. Trying this out Differential Revision: D55496044
JacobSzwejbka
force-pushed
the
export-D55496044
branch
from
12177e5 to
b4750be
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55496044 |
iseeyuan
approved these changes
Mar 29, 2024
JacobSzwejbka
force-pushed
the
export-D55496044
branch
from
b4750be to
25289a8
Compare
JacobSzwejbka
added a commit
to JacobSzwejbka/executorch-1
that referenced
this pull request
Mar 29, 2024
Summary: Lots of bugs before with kv cache implementation of runner. Trying this out Reviewed By: iseeyuan Differential Revision: D55496044
|
This pull request was exported from Phabricator. Differential Revision: D55496044 |
JacobSzwejbka
added a commit
to JacobSzwejbka/executorch-1
that referenced
this pull request
Mar 29, 2024
Summary: Lots of bugs before with kv cache implementation of runner. Trying this out The bugs were mostly various ways that the prompt sequence was getting trashed in kv cache mode Reviewed By: iseeyuan Differential Revision: D55496044
JacobSzwejbka
force-pushed
the
export-D55496044
branch
from
25289a8 to
ef85852
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55496044 |
JacobSzwejbka
added a commit
to JacobSzwejbka/executorch-1
that referenced
this pull request
Mar 29, 2024
Summary: Lots of bugs before with kv cache implementation of runner. Trying this out The bugs were mostly various ways that the prompt sequence was getting trashed in kv cache mode Reviewed By: iseeyuan Differential Revision: D55496044
JacobSzwejbka
force-pushed
the
export-D55496044
branch
from
ef85852 to
c9fc557
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55496044 |
Summary: Lots of bugs before with kv cache implementation of runner. Trying this out The bugs were mostly various ways that the prompt sequence was getting trashed in kv cache mode Reviewed By: iseeyuan Differential Revision: D55496044
JacobSzwejbka
force-pushed
the
export-D55496044
branch
from
c9fc557 to
88dcd2c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55496044 |
|
This pull request has been merged in 05b0d3a. |
dbort
pushed a commit
to dbort/executorch
that referenced
this pull request
Mar 30, 2024
Summary: Pull Request resolved: pytorch#2752 Lots of bugs before with kv cache implementation of runner. Trying this out The bugs were mostly various ways that the prompt sequence was getting trashed in kv cache mode Reviewed By: iseeyuan Differential Revision: D55496044 fbshipit-source-id: c98cbb26ce022981eb7eddbadd57037bad94739a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Lots of bugs before with kv cache implementation of runner. Trying this out
Differential Revision: D55496044