Skip to content

Restrict promoting commit to stable branch by including Android & Apple jobs #2757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

guangy10
Copy link
Contributor

@guangy10 guangy10 commented Mar 29, 2024

Hardening our OSS CI. Just realized recently added jobs Apple/Android demo apps are not included in the stable branch check.

Stack from ghstack (oldest at bottom):

Differential Revision: D55510295

guangy10 added a commit that referenced this pull request Mar 29, 2024
Copy link

pytorch-bot bot commented Mar 29, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/2757

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit ba45ca5 with merge base 57e3449 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 29, 2024
guangy10 added a commit that referenced this pull request Mar 29, 2024
@guangy10
Copy link
Contributor Author

@guangy10 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@guangy10 guangy10 changed the title Restrict promoting commit to stable branch by including Android & Aplle jobs Restrict promoting commit to stable branch by including Android & Apple jobs Mar 29, 2024
@guangy10
Copy link
Contributor Author

@guangy10 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Copy link
Contributor

@huydhn huydhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@facebook-github-bot
Copy link
Contributor

@guangy10 merged this pull request in f0c6666.

dbort pushed a commit to dbort/executorch that referenced this pull request Mar 30, 2024
…le jobs (pytorch#2757)

Summary:
Pull Request resolved: pytorch#2757

Hardening our OSS CI. Just realized recently added jobs Apple/Android demo apps are not included in the stable branch check.

imported-using-ghimport

Test Plan: Imported from OSS

Reviewed By: huydhn

Differential Revision: D55510295

Pulled By: guangy10

fbshipit-source-id: 6a04c8e45e32297b2f9e6ec2f7a5bffda81e301a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants