[ET-VK] Refactor Pool.cpp #2836
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds more lines than it subtracts, but it'll be worth it once we reuse the methods for `aten.convolution`. Differential Revision: [D55706057](https://our.internmc.facebook.com/intern/diff/D55706057/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/2836
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 4c21015 with merge base d3326a2 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
This was referenced Apr 3, 2024
|
This pull request was exported from Phabricator. Differential Revision: D55706057 |
jorgep31415
added a commit
that referenced
this pull request
Apr 3, 2024
This change adds more lines than it subtracts, but it'll be worth it once we reuse the methods for `aten.convolution`. Differential Revision: [D55706057](https://our.internmc.facebook.com/intern/diff/D55706057/) ghstack-source-id: 221165542 Pull Request resolved: #2836
copyrightly
approved these changes
Apr 3, 2024
This change adds more lines than it subtracts, but it'll be worth it once we reuse the methods for `aten.convolution`. Differential Revision: [D55706057](https://our.internmc.facebook.com/intern/diff/D55706057/) [ghstack-poisoned]
This was referenced Apr 4, 2024
|
This pull request was exported from Phabricator. Differential Revision: D55706057 |
This was referenced Apr 5, 2024
Closed
This change adds more lines than it subtracts, but it'll be worth it once we reuse the methods for `aten.convolution`. Differential Revision: [D55706057](https://our.internmc.facebook.com/intern/diff/D55706057/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D55706057 |
|
This pull request has been merged in 1ae8aa5. |
Closed
kedarnath03
pushed a commit
to kedarnath03/executorch
that referenced
this pull request
Jun 25, 2025
Pull Request resolved: pytorch/executorch#2836 This change adds more lines than it subtracts, but it'll be worth it once we reuse the methods for `aten.convolution`. ghstack-source-id: 221721759 @exported-using-ghexport Differential Revision: [D55706057](https://our.internmc.facebook.com/intern/diff/D55706057/)
kedarnath03
pushed a commit
to kedarnath03/executorch
that referenced
this pull request
Jun 25, 2025
Pull Request resolved: pytorch/executorch#2836 This change adds more lines than it subtracts, but it'll be worth it once we reuse the methods for `aten.convolution`. ghstack-source-id: 221216591 @exported-using-ghexport Differential Revision: [D55706057](https://our.internmc.facebook.com/intern/diff/D55706057/)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
This change adds more lines than it subtracts, but it'll be worth it once we reuse the methods for
aten.convolution.Differential Revision: D55706057