Custom ops API small fixes #2936
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/2936
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit c5394d2 with merge base 554cd27 ( BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D55907751 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Apr 9, 2024
Summary: Fix the way we use `at::from_blob()` and add proper namespace to `CompileTimeFunctionPointer` so to not confused with `at::CompileTimeFunctionPointer`. Differential Revision: D55907751
facebook-github-bot
force-pushed
the
export-D55907751
branch
from
9c2b0d7 to
f80150f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55907751 |
larryliu0820
added a commit
that referenced
this pull request
Apr 9, 2024
Summary: Fix the way we use `at::from_blob()` and add proper namespace to `CompileTimeFunctionPointer` so to not confused with `at::CompileTimeFunctionPointer`. Differential Revision: D55907751
larryliu0820
force-pushed
the
export-D55907751
branch
from
f80150f to
44737b9
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55907751 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Apr 9, 2024
Summary: Fix the way we use `at::from_blob()` and add proper namespace to `CompileTimeFunctionPointer` so to not confused with `at::CompileTimeFunctionPointer`. Differential Revision: D55907751
facebook-github-bot
force-pushed
the
export-D55907751
branch
from
44737b9 to
6732206
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55907751 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Apr 9, 2024
Summary: Fix the way we use `at::from_blob()` and add proper namespace to `CompileTimeFunctionPointer` so to not confused with `at::CompileTimeFunctionPointer`. Differential Revision: D55907751
facebook-github-bot
force-pushed
the
export-D55907751
branch
from
6732206 to
4107639
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55907751 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Apr 10, 2024
Summary: Fix the way we use `at::from_blob()` and add proper namespace to `CompileTimeFunctionPointer` so to not confused with `at::CompileTimeFunctionPointer`. Reviewed By: lucylq Differential Revision: D55907751
facebook-github-bot
force-pushed
the
export-D55907751
branch
from
4107639 to
867be8c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55907751 |
larryliu0820
added a commit
that referenced
this pull request
Apr 10, 2024
Summary: Fix the way we use `at::from_blob()` and add proper namespace to `CompileTimeFunctionPointer` so to not confused with `at::CompileTimeFunctionPointer`. Reviewed By: lucylq Differential Revision: D55907751
larryliu0820
force-pushed
the
export-D55907751
branch
from
867be8c to
9bb4d11
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55907751 |
lucylq
approved these changes
Apr 10, 2024
facebook-github-bot
force-pushed
the
export-D55907751
branch
from
9bb4d11 to
8823090
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55907751 |
Summary: Fix the way we use `at::from_blob()` and add proper namespace to `CompileTimeFunctionPointer` so to not confused with `at::CompileTimeFunctionPointer`. bypass-github-pytorch-ci-checks bypass-export-ci-checks Reviewed By: lucylq Differential Revision: D55907751
larryliu0820
force-pushed
the
export-D55907751
branch
from
8823090 to
c5394d2
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55907751 |
|
This pull request has been merged in 8f8d969. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Fix the way we use
at::from_blob()and add proper namespace toCompileTimeFunctionPointerso to not confused withat::CompileTimeFunctionPointer.Differential Revision: D55907751