[ET-VK][Ez] Introduce convenience constexpr for StorageTypes and GPUMemoryLayouts
#2948
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…PUMemoryLayout`s ## Context Introduce the following convenience `constexpr`: * `api::kBuffer`, `api::kTexture3D`, and `api::kTexture2D` * `api::kWidthPacked`, `api::kHeightPacked`, and `api::kChannelsPacked` Also remove the `api::StorageType::UNKNOWN` enum entry as it doesn't really serve any purpose. Differential Revision: [D55811278](https://our.internmc.facebook.com/intern/diff/D55811278/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/2948
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 3f953f3 with merge base d309e9d ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D55811278 |
SS-JIA
added a commit
that referenced
this pull request
Apr 9, 2024
…PUMemoryLayout`s ## Context Introduce the following convenience `constexpr`: * `api::kBuffer`, `api::kTexture3D`, and `api::kTexture2D` * `api::kWidthPacked`, `api::kHeightPacked`, and `api::kChannelsPacked` Also remove the `api::StorageType::UNKNOWN` enum entry as it doesn't really serve any purpose. Differential Revision: [D55811278](https://our.internmc.facebook.com/intern/diff/D55811278/) ghstack-source-id: 221859517 Pull Request resolved: #2948
…pe`s and `GPUMemoryLayout`s" ## Context Introduce the following convenience `constexpr`: * `api::kBuffer`, `api::kTexture3D`, and `api::kTexture2D` * `api::kWidthPacked`, `api::kHeightPacked`, and `api::kChannelsPacked` Also remove the `api::StorageType::UNKNOWN` enum entry as it doesn't really serve any purpose. Differential Revision: [D55811278](https://our.internmc.facebook.com/intern/diff/D55811278/) [ghstack-poisoned]
SS-JIA
added a commit
that referenced
this pull request
Apr 9, 2024
…PUMemoryLayout`s Pull Request resolved: #2948 ## Context Introduce the following convenience `constexpr`: * `api::kBuffer`, `api::kTexture3D`, and `api::kTexture2D` * `api::kWidthPacked`, `api::kHeightPacked`, and `api::kChannelsPacked` Also remove the `api::StorageType::UNKNOWN` enum entry as it doesn't really serve any purpose. Differential Revision: [D55811278](https://our.internmc.facebook.com/intern/diff/D55811278/) ghstack-source-id: 221868427
|
This pull request was exported from Phabricator. Differential Revision: D55811278 |
…pe`s and `GPUMemoryLayout`s" ## Context Introduce the following convenience `constexpr`: * `api::kBuffer`, `api::kTexture3D`, and `api::kTexture2D` * `api::kWidthPacked`, `api::kHeightPacked`, and `api::kChannelsPacked` Also remove the `api::StorageType::UNKNOWN` enum entry as it doesn't really serve any purpose. Differential Revision: [D55811278](https://our.internmc.facebook.com/intern/diff/D55811278/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D55811278 |
SS-JIA
added a commit
that referenced
this pull request
Apr 9, 2024
…PUMemoryLayout`s Pull Request resolved: #2948 ## Context Introduce the following convenience `constexpr`: * `api::kBuffer`, `api::kTexture3D`, and `api::kTexture2D` * `api::kWidthPacked`, `api::kHeightPacked`, and `api::kChannelsPacked` Also remove the `api::StorageType::UNKNOWN` enum entry as it doesn't really serve any purpose. ghstack-source-id: 221871428 Differential Revision: [D55811278](https://our.internmc.facebook.com/intern/diff/D55811278/)
jorgep31415
approved these changes
Apr 9, 2024
|
This pull request has been merged in b26eee8. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
StorageTypes andGPUMemoryLayouts #2948Context
Introduce the following convenience
constexpr:api::kBuffer,api::kTexture3D, andapi::kTexture2Dapi::kWidthPacked,api::kHeightPacked, andapi::kChannelsPackedAlso remove the
api::StorageType::UNKNOWNenum entry as it doesn't really serve any purpose.Differential Revision: D55811278