Skip to content

Add TorchFix linter #298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Add TorchFix linter #298

wants to merge 2 commits into from

Conversation

kit1980
Copy link
Contributor

@kit1980 kit1980 commented Sep 13, 2023

Besides adding to the CI, updated exir/emit/test/test_emit.py to fix TOR101 "Use of deprecated function torch.nn.UpsamplingNearest2d"

Lint error "Advice (FLAKE8) C901 'PermuteMemoryFormatsPass.call' is too complex (13)" is pre-existing.

@kit1980 kit1980 requested a review from huydhn September 13, 2023 00:17
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 13, 2023
@kit1980 kit1980 marked this pull request as ready for review September 13, 2023 01:33
@facebook-github-bot
Copy link
Contributor

@kit1980 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@kit1980 merged this pull request in 31aaa12.

@digantdesai
Copy link
Contributor

TOR101 "Use of deprecated function torch.nn.UpsamplingNearest2d"

Nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants