Forward fix macOS jobs after test-infra #5086 #2980
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/2980
Note: Links to docs will display an error until the docs builds have been completed. ❌ 4 New FailuresAs of commit 6f967c3 with merge base 859e924 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
@huydhn has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
huydhn
changed the title
larryliu0820
approved these changes
Apr 10, 2024
|
@pytorchbot cherry-pick --onto release/0.2 -c regression |
Cherry picking #2980The cherry pick PR is at #3020 and it is recommended to link a regression cherry pick PR with an issue Details for Dev Infra teamRaised by workflow job |
pytorchbot
pushed a commit
that referenced
this pull request
Apr 12, 2024
Summary: After pytorch/test-infra#5086, the working directory is now set correctly, so `pushd` isn't needed anymore. More importantly, trying to change the directory ends up failing all macOS CI jobs because that subdirectory doesn't exist. Pull Request resolved: #2980 Reviewed By: larryliu0820 Differential Revision: D55996299 Pulled By: huydhn fbshipit-source-id: 05758603d7628cc0a01fd577a49202d45c84e6c5 (cherry picked from commit 2fc99b0)
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After pytorch/test-infra#5086, the working directory is now set correctly, so
pushdisn't needed anymore. More importantly, trying to change the directory ends up failing all macOS CI jobs because that subdirectory doesn't exist.