Add semihosting to cmake for executor_runner #3008
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3008
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 3720e16 with merge base 910f851 ( BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
per
added
ciflow/trunk
partner: arm
Add cmake option to enable semihosting for the executor runner application. Change-Id: I5db7271413b39e5122f86f321d15dd2a1086a547
digantdesai
approved these changes
Apr 23, 2024
| ) | ||
|
|
||
| if(SEMIHOSTING) | ||
| add_link_options(--specs=rdimon.specs) |
There was a problem hiding this comment.
Can you include a rationale for enabling this in the commit / PR summary?
| target_compile_definitions(arm_executor_runner PUBLIC SEMIHOSTING) | ||
| endif() | ||
|
|
||
| # Fixup compilation of retarget.c |
There was a problem hiding this comment.
Also create a ET GH task and refer that here?
|
@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@digantdesai merged this pull request in 6712185. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add cmake option to enable semihosting for the executor runner application.
Change-Id: I5db7271413b39e5122f86f321d15dd2a1086a547