Change tokenizer name to bpe_tokenizer and extract a base class #3009
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3009
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 4d1d502 with merge base 17c64a3 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D56052583 |
|
This pull request was exported from Phabricator. Differential Revision: D56052583 |
larryliu0820
added a commit
that referenced
this pull request
Apr 12, 2024
Summary: Pull Request resolved: #3009 We want to be able to support more than 1 implementation of tokenizer. Currently `tokenizer.cpp` is adopted from `llama2.c` but we also wanted to support `Tiktoken` (will be added in next PR). This PR extract out a base class `Tokenizer` and make it extendable by different implementations. Differential Revision: D56052583
larryliu0820
force-pushed
the
export-D56052583
branch
from
d68a45b to
37368da
Compare
|
This pull request was exported from Phabricator. Differential Revision: D56052583 |
larryliu0820
added a commit
that referenced
this pull request
Apr 12, 2024
Summary: Pull Request resolved: #3009 We want to be able to support more than 1 implementation of tokenizer. Currently `tokenizer.cpp` is adopted from `llama2.c` but we also wanted to support `Tiktoken` (will be added in next PR). This PR extract out a base class `Tokenizer` and make it extendable by different implementations. Differential Revision: D56052583
larryliu0820
force-pushed
the
export-D56052583
branch
from
37368da to
1a42760
Compare
|
This pull request was exported from Phabricator. Differential Revision: D56052583 |
larryliu0820
added a commit
that referenced
this pull request
Apr 12, 2024
Summary: Pull Request resolved: #3009 We want to be able to support more than 1 implementation of tokenizer. Currently `tokenizer.cpp` is adopted from `llama2.c` but we also wanted to support `Tiktoken` (will be added in next PR). This PR extract out a base class `Tokenizer` and make it extendable by different implementations. Differential Revision: D56052583
larryliu0820
force-pushed
the
export-D56052583
branch
from
1a42760 to
fd635c5
Compare
|
This pull request was exported from Phabricator. Differential Revision: D56052583 |
larryliu0820
added a commit
that referenced
this pull request
Apr 12, 2024
Summary: Pull Request resolved: #3009 We want to be able to support more than 1 implementation of tokenizer. Currently `tokenizer.cpp` is adopted from `llama2.c` but we also wanted to support `Tiktoken` (will be added in next PR). This PR extract out a base class `Tokenizer` and make it extendable by different implementations. Differential Revision: D56052583
larryliu0820
force-pushed
the
export-D56052583
branch
from
fd635c5 to
473f107
Compare
|
This pull request was exported from Phabricator. Differential Revision: D56052583 |
larryliu0820
added a commit
that referenced
this pull request
Apr 12, 2024
Summary: Pull Request resolved: #3009 We want to be able to support more than 1 implementation of tokenizer. Currently `tokenizer.cpp` is adopted from `llama2.c` but we also wanted to support `Tiktoken` (will be added in next PR). This PR extract out a base class `Tokenizer` and make it extendable by different implementations. Differential Revision: D56052583
larryliu0820
force-pushed
the
export-D56052583
branch
from
473f107 to
0603bc5
Compare
mergennachin
approved these changes
Apr 12, 2024
|
This pull request was exported from Phabricator. Differential Revision: D56052583 |
larryliu0820
added a commit
that referenced
this pull request
Apr 12, 2024
Summary: Pull Request resolved: #3009 We want to be able to support more than 1 implementation of tokenizer. Currently `tokenizer.cpp` is adopted from `llama2.c` but we also wanted to support `Tiktoken` (will be added in next PR). This PR extract out a base class `Tokenizer` and make it extendable by different implementations. Reviewed By: mergennachin Differential Revision: D56052583
larryliu0820
force-pushed
the
export-D56052583
branch
from
0603bc5 to
084fad1
Compare
Summary: Pull Request resolved: #3009 We want to be able to support more than 1 implementation of tokenizer. Currently `tokenizer.cpp` is adopted from `llama2.c` but we also wanted to support `Tiktoken` (will be added in next PR). This PR extract out a base class `Tokenizer` and make it extendable by different implementations. Reviewed By: mergennachin Differential Revision: D56052583
|
This pull request was exported from Phabricator. Differential Revision: D56052583 |
larryliu0820
force-pushed
the
export-D56052583
branch
from
084fad1 to
4d1d502
Compare
|
This pull request has been merged in 21fdc4e. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
We want to be able to support more than 1 implementation of tokenizer. Currently
tokenizer.cppis adopted fromllama2.cbut we also wanted to supportTiktoken(will be added in next PR).This PR extract out a base class
Tokenizerand make it extendable by different implementations.Differential Revision: D56052583