quant_params should come from implicit nodes #301
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D48805092 |
|
This pull request was exported from Phabricator. Differential Revision: D48805092 |
mcr229
force-pushed
the
export-D48805092
branch
from
75001d1 to
aee5fa1
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48805092 |
mcr229
force-pushed
the
export-D48805092
branch
from
aee5fa1 to
12d4a8e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48805092 |
mcr229
force-pushed
the
export-D48805092
branch
from
12d4a8e to
a4f9f1a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48805092 |
mcr229
force-pushed
the
export-D48805092
branch
from
a4f9f1a to
0ac9c5f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48805092 |
mcr229
force-pushed
the
export-D48805092
branch
from
0ac9c5f to
6c1f3f6
Compare
Differential Revision: D48761858 fbshipit-source-id: 4978bf4d68f16bf67ad5f6870d3e6a501fd7b9ed
Differential Revision: D48761859 fbshipit-source-id: 468e56a1e023b5d7cdc67098e108a4b1d140ee0c
Differential Revision: D48790083 fbshipit-source-id: 8115ccad6091403a1758908fdd534074695ff3a5
Differential Revision: D48764114 fbshipit-source-id: 105b9c514f974d761a14133b4c5fa5fdc44610d1
Differential Revision: D48805091 fbshipit-source-id: a13065c01ecfe0068dd0a73397fe2d43a2b52c84
Summary: Pull Request resolved: pytorch/executorch#301 QuantParams are generated for nodes to imply that these operations are quantized operations. However, if the QuantNodes are explicit, i.e. being used to actually convert data type, then we should not be generating quant_params. This is to help with mixed-datatype modles Reviewed By: salilsdesai Differential Revision: D48805092 fbshipit-source-id: 1babc4a87bf8f492657658462847a2e262b40054
|
This pull request was exported from Phabricator. Differential Revision: D48805092 |
mcr229
force-pushed
the
export-D48805092
branch
from
6c1f3f6 to
6e120cf
Compare
|
This pull request has been merged in a0e9dba. |
Gasoonjia
pushed a commit
that referenced
this pull request
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
QuantParams are generated for nodes to imply that these operations are quantized operations. However, if the QuantNodes are explicit, i.e. being used to actually convert data type, then we should not be generating quant_params.
This is to help with mixed-datatype modles
Reviewed By: salilsdesai
Differential Revision: D48805092