Skip to content

Update method name for tester #3016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

digantdesai
Copy link
Contributor

Summary: Method name update

Differential Revision: D56072265

Copy link

pytorch-bot bot commented Apr 12, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3016

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 3 Unrelated Failures

As of commit 38d04b6 with merge base 057e432 (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 12, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D56072265

digantdesai added a commit to digantdesai/executorch-1 that referenced this pull request Apr 12, 2024
Summary:

Method name update

Reviewed By: mcr229

Differential Revision: D56072265
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D56072265

digantdesai added a commit to digantdesai/executorch-1 that referenced this pull request Apr 15, 2024
Summary:

Method name update

Reviewed By: mcr229

Differential Revision: D56072265
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D56072265

Summary:

Method name update

Reviewed By: mcr229

Differential Revision: D56072265
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D56072265

@freddan80
Copy link
Collaborator

LGTM, but I have fixed the issues in a slightly different way in #2991. I'd prefer that since it's using the new and shiny method

@digantdesai digantdesai closed this Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants