-
Notifications
You must be signed in to change notification settings - Fork 607
Update doc-build.yml #3045
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update doc-build.yml #3045
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3045
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 06a77ce with merge base ab62707 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
@svekars has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
exit 1 | ||
case "${REF_NAME}" in | ||
*-rc*) | ||
echo "Aborting upload since this is an RC tag: ${REF_NAME}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a comment explaining why it makes sense to abort when encountering an RC tag. Is it because we only want to generate docs for the actual release tag?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, I believe this is what we do across other repositories - no documentation will be generated for v1.0.0-rc1 or similar.
ae28016
to
b78d28b
Compare
@svekars has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
@pytorchbot cherry-pick --onto release/0.2 -c docs |
Cherry picking #3045The cherry pick PR is at #3098 Details for Dev Infra teamRaised by workflow job |
Summary: Pull Request resolved: #3045 Reviewed By: clee2000 Differential Revision: D56201946 Pulled By: svekars fbshipit-source-id: 4212c24b02a1229ff06137b0d437b4e8c5dd454e (cherry picked from commit c73bfc0) Co-authored-by: Svetlana Karslioglu <[email protected]>
No description provided.