clean up TODOs #310
Closed
clean up TODOs #310
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D49129706 |
|
This pull request was exported from Phabricator. Differential Revision: D49129706 |
mcr229
force-pushed
the
export-D49129706
branch
from
dc496c1 to
84f146a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49129706 |
mcr229
force-pushed
the
export-D49129706
branch
from
84f146a to
c39a606
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49129706 |
mcr229
force-pushed
the
export-D49129706
branch
from
c39a606 to
c7c4bab
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49129706 |
mcr229
force-pushed
the
export-D49129706
branch
from
c7c4bab to
19d6e1a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49129706 |
mcr229
force-pushed
the
export-D49129706
branch
from
19d6e1a to
4f17404
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49129706 |
mcr229
force-pushed
the
export-D49129706
branch
from
4f17404 to
ce5ebd8
Compare
Differential Revision: D48761858 fbshipit-source-id: d6bb4b17687217dcf0e536efa312643b958f9855
Differential Revision: D48761859 fbshipit-source-id: 32a6b61157b1c571b45794038dfcec90ecb26388
Differential Revision: D48790083 fbshipit-source-id: 02f62676813864ecd656dff09e66860b27fab6fe
Differential Revision: D48764114 fbshipit-source-id: 1c1185fa4542460463d506762aab2f0f64706584
Differential Revision: D48805091 fbshipit-source-id: 669e31967facb8b9e5fdf5cb6d8c0deb9a4216e5
Differential Revision: D48805092 fbshipit-source-id: 2d19d943d54b6fc6d396755d228484f9fb42d674
Differential Revision: D49214926 fbshipit-source-id: c9ce9a0d612b2ab9b7444b650bbbe742174c3fd3
Differential Revision: D49214927 fbshipit-source-id: 98d914e23ebdfac0483f99e3623c0813124cbc89
Differential Revision: https://internalfb.com/D49116826 fbshipit-source-id: 9a6b7c877f803bdef1e1d922a2829c817286e28e
Differential Revision: D49116827 fbshipit-source-id: e49ef7a950d22be924a23f8e8bf69003147ced6b
Summary: Pull Request resolved: pytorch/executorch#310 With Unified Partitioner (D48761226) and Duplicate Dequant Node (D48663147) pass landing, we can clean up the TODOs from this example _check_ir_validity is still required for quantization workflow as without it, it complains that quantized ops are not aten canonical Reviewed By: kirklandsign Differential Revision: D49129706 fbshipit-source-id: 867d85f1dde8da5244434d650add08d2e552d1ae
|
This pull request was exported from Phabricator. Differential Revision: D49129706 |
mcr229
force-pushed
the
export-D49129706
branch
from
ce5ebd8 to
286dddc
Compare
|
This pull request has been merged in e697d21. |
Gasoonjia
pushed a commit
that referenced
this pull request
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
With Unified Partitioner (D48761226) and Duplicate Dequant Node (D48663147) pass landing, we can clean up the TODOs from this example
_check_ir_validity is still required for quantization workflow as without it, it complains that quantized ops are not aten canonical
Reviewed By: kirklandsign
Differential Revision: D49129706