Skip to content

support emit sym value from delegate #3103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

cccclai
Copy link
Contributor

@cccclai cccclai commented Apr 17, 2024

Summary:
For dynamic shape, if delegate output is dynamic shape, the return might be something like (s0, x, y), and s0 is a sym type while others are fake tensor. In this case, we will emit the sym value (including SymFloat, SymBool, SymInt) to a unique Evalue.

Since the sym type node will have an empty spec, we use the node.meta['val'] to find out it's a sym type node.

Differential Revision: D56176100

Copy link

pytorch-bot bot commented Apr 17, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3103

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 9198a14 with merge base 1eed125 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 17, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D56176100

cccclai added a commit to cccclai/executorch-1 that referenced this pull request Apr 17, 2024
Summary:

For dynamic shape, if delegate output is dynamic shape, the return might be something like `(s0, x, y)`, and `s0` is a sym type while others are fake tensor. In this case, we will emit the sym value (including `SymFloat`, `SymBool`, `SymInt`) to a unique Evalue. 

Since the sym type node will have an empty spec, we use the `node.meta['val']` to find out it's a sym type node.

Differential Revision: D56176100
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D56176100

Summary:

For dynamic shape, if delegate output is dynamic shape, the return might be something like `(s0, x, y)`, and `s0` is a sym type while others are fake tensor. In this case, we will emit the sym value (including `SymFloat`, `SymBool`, `SymInt`) to a unique Evalue. 

Since the sym type node will have an empty spec, we use the `node.meta['val']` to find out it's a sym type node.

Reviewed By: mcr229

Differential Revision: D56176100
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D56176100

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 73599f4.

@mergennachin mergennachin mentioned this pull request Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants