update index: dtype constraints changed in ATen #321
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D49218705 |
manuelcandales
force-pushed
the
export-D49218705
branch
from
c3f3c27 to
f77f842
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49218705 |
manuelcandales
force-pushed
the
export-D49218705
branch
from
f77f842 to
c04e85f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49218705 |
Summary: Previously reported index [issue](pytorch/pytorch#107698) related to input/out type conversion was fixed in ATen, by requiring out tensor to have the same dtype than input tensor. This diffs updates the portable index kernel, to stay Dtype-compliant. Reviewed By: larryliu0820 Differential Revision: D49218705
manuelcandales
force-pushed
the
export-D49218705
branch
from
c04e85f to
88c9110
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49218705 |
|
This pull request has been merged in 270c80d. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Previously reported index issue related to input/out type conversion was fixed in ATen, by requiring out tensor to have the same dtype than input tensor.
This diffs updates the portable index kernel, to stay Dtype-compliant.
Reviewed By: larryliu0820
Differential Revision: D49218705