Skip to content

Remove preview wording and TODOs from README #3374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Remove preview wording and TODOs from README #3374

wants to merge 1 commit into from

Conversation

orionr
Copy link
Contributor

@orionr orionr commented Apr 26, 2024

Refining the README.md to not include preview wording now that we are at alpha and also no TODO in the directory structure.

@orionr
Remove preview wording and TODOs from README
a9524fd 
Refining the README.md to not include preview wording now that we are at alpha and also no TODO in the directory structure.
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Apr 26, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3374

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit a9524fd with merge base 44d4bac (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 26, 2024
@orionr orionr requested review from dbort and mergennachin April 26, 2024 17:41
mergennachin
mergennachin reviewed Apr 26, 2024
View reviewed changes
Copy link
Contributor

@mergennachin mergennachin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you wanna have the same content as the doc website? https://pytorch.org/executorch/main/index.html

In particular, "This is an alpha release; the ExecuTorch APIs and ..."

@orionr
Copy link
Contributor Author

orionr commented Apr 26, 2024

Up to you guys. I wanted to just slim it down so we don't have too much detail on release version and instead we focus on that with the website. I'll defer to @dbort on this one, though.

@facebook-github-bot
Copy link
Contributor

@orionr has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@mergennachin mergennachin mentioned this pull request Apr 26, 2024
Closed
@dbort dbort mentioned this pull request Apr 26, 2024
Merged
@facebook-github-bot
Copy link
Contributor

@orionr merged this pull request in f3c5695.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mergennachin mergennachin mergennachin approved these changes

@dbort dbort dbort approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@orionr @facebook-github-bot @mergennachin @dbort