Skip to content

event_tracer logging inside method.cpp and program.cpp #346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

event_tracer logging inside method.cpp and program.cpp #346

wants to merge 1 commit into from

Conversation

tarun292
Copy link
Contributor

Summary:
Adding event_tracer logging inside method.cpp and program.cpp.

Similar to D48975975 calls to both internal::ET_EVENT_TRACER_SCOPE_PROF and EXECUTORCH_SCOPE_PROF are present in method.cpp and program.cpp. Calls to event_tracer_* are a no-op for now and EXECUTORCH_SCOPE_PROF will be deprecated soon.

Differential Revision: D49220572

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported labels Sep 14, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49220572

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49220572

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49220572

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49220572

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49220572

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49220572

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49220572

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49220572

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49220572

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49220572

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49220572

@tarun292 tarun292 force-pushed the export-D49220572 branch 2 times, most recently from 9dc91da to 53a9878 Compare September 22, 2023 00:24
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49220572

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49220572

@netlify
Copy link

netlify bot commented Sep 22, 2023 •
edited
Loading

✅ Deploy Preview for resplendent-gnome-14e531 canceled.

Name Link
🔨 Latest commit edc638b
🔍 Latest deploy log https://app.netlify.com/sites/resplendent-gnome-14e531/deploys/650ddf0b0315710008c662ef

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49220572

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49220572

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49220572

@tarun292 @facebook-github-bot
event_tracer logging inside method.cpp and program.cpp (#346)
edc638b 
Summary:

Adding event_tracer logging inside method.cpp and program.cpp.

Similar to D48975975 calls to both `internal::ET_EVENT_TRACER_SCOPE_PROF` and `EXECUTORCH_SCOPE_PROF` are present in `method.cpp` and `program.cpp`. Calls to `event_tracer_*` are a no-op for now and `EXECUTORCH_SCOPE_PROF` will be deprecated soon.

Reviewed By: dbort

Differential Revision: D49220572
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49220572

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in c19b58f.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tarun292 @facebook-github-bot