-
Notifications
You must be signed in to change notification settings - Fork 606
Add a script for generating OSS gtest CMakeLists.txt #3608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3608
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 8682790 with merge base f873074 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
@kirklandsign has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
5090416
to
026f6e4
Compare
@kirklandsign has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
026f6e4
to
51dbed3
Compare
Use runtime/core/test as example: python test/utils.generate_gtest_cmake_lists.py Then run sh test/run_oss_cpp_tests.sh Note: for generate_gtest_cmake_lists.py CONFIG, you can use buck ``` buck cquery "inputs(deps('//runtime/core/test/...'))" | grep test.cpp ``` to get test srcs. However, manual check is needed. After this, all runtime/core OSS tests are added.
51dbed3
to
f946ff0
Compare
@kirklandsign has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
import subprocess | ||
|
||
|
||
TEMPLATE = """# Copyright (c) Meta Platforms, Inc. and affiliates. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you move this out into a template file? Like for pytorch they have https://github.com/pytorch/pytorch/blob/main/cmake/TorchConfig.cmake.in
@kirklandsign has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
@kirklandsign has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
@kirklandsign merged this pull request in 7a35b6f. |
No description provided.