Skip to content

Add a script for generating OSS gtest CMakeLists.txt #3608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

kirklandsign
Copy link
Contributor

No description provided.

Copy link

pytorch-bot bot commented May 14, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3608

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 8682790 with merge base f873074 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 14, 2024
@facebook-github-bot
Copy link
Contributor

@kirklandsign has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@kirklandsign has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@kirklandsign kirklandsign changed the title Add tooling for generating OSS test CMakeLists.txt Add a script for generating OSS test CMakeLists.txt May 15, 2024
@kirklandsign kirklandsign changed the title Add a script for generating OSS test CMakeLists.txt Add a script for generating OSS gtest CMakeLists.txt May 15, 2024
@kirklandsign kirklandsign requested a review from larryliu0820 May 15, 2024 16:25
Use runtime/core/test as example:
python test/utils.generate_gtest_cmake_lists.py

Then run
sh test/run_oss_cpp_tests.sh

Note: for generate_gtest_cmake_lists.py CONFIG, you can use buck
```
buck cquery "inputs(deps('//runtime/core/test/...'))" | grep test.cpp
```
to get test srcs. However, manual check is needed.

After this, all runtime/core OSS tests are added.
@facebook-github-bot
Copy link
Contributor

@kirklandsign has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

import subprocess


TEMPLATE = """# Copyright (c) Meta Platforms, Inc. and affiliates.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you move this out into a template file? Like for pytorch they have https://github.com/pytorch/pytorch/blob/main/cmake/TorchConfig.cmake.in

@facebook-github-bot
Copy link
Contributor

@kirklandsign has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@kirklandsign has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@kirklandsign merged this pull request in 7a35b6f.

@kirklandsign kirklandsign deleted the generate-cmake branch May 16, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants