Add helper to resolve debug handles of Event #368
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D49117148 |
|
This pull request was exported from Phabricator. Differential Revision: D49117148 |
Jack-Khuu
force-pushed
the
export-D49117148
branch
from
37a8487 to
cea0074
Compare
Summary: Pull Request resolved: pytorch/executorch#367 This diff ingests the `ETDump Flatcc` and populates the EventBlocks/Events in the `Inspector` constructor Notably: This diff only consumes the profile events entries Differential Revision: https://internalfb.com/D49100624 fbshipit-source-id: d7546d3aeac92e60d4e6aa3e325260dfc93a3397
Summary: Pull Request resolved: pytorch/executorch#368 Add a linking function in the form of `_gen_resolve_debug_handles` It takes the derived EventBlocks (profiling info, etc.) and links it to ETRecord ("Debug Symbols") via the provided debug_handles --- Note: this function only resolves the link (updates the debug_handles field), but does not join the components themselves Reviewed By: tarun292 Differential Revision: D49117148 fbshipit-source-id: 7bc1adf7e72b76b107f56c4aa9c7a4df07c8c1da
|
This pull request was exported from Phabricator. Differential Revision: D49117148 |
Jack-Khuu
force-pushed
the
export-D49117148
branch
from
cea0074 to
4aa3c6b
Compare
|
This pull request has been merged in 7b29899. |
Gasoonjia
pushed a commit
that referenced
this pull request
Jul 30, 2024
* add --parallel-prefill options, option validation, and refactor option validation * handle model is None for model validation * typo * move model compile opttions to generator args * typo * typo * typo * refactor * update eval
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Add a linking function in the form of
_gen_resolve_debug_handlesIt takes the derived EventBlocks (profiling info, etc.) and links it to ETRecord ("Debug Symbols") via the provided debug_handles
Note: this function only resolves the link (updates the debug_handles field), but does not join the components themselves
Differential Revision: D49117148