add long running tag to e2e model tests #372
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D49279457 |
Summary: Models take longer to capture especially without dev-nosan mode. So in testing xnnpack models, a lot of these end to end tests time out and end up ommitted. Since models generally take longer, we can add the long running tag to keep them from timing out on CI Reviewed By: digantdesai Differential Revision: D49279457
mcr229
force-pushed
the
export-D49279457
branch
from
df7c218 to
e3202b6
Compare
✅ Deploy Preview for resplendent-gnome-14e531 canceled.
|
|
This pull request was exported from Phabricator. Differential Revision: D49279457 |
|
This pull request has been merged in f533d5a. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Models take longer to capture especially without dev-nosan mode. So in testing xnnpack models, a lot of these end to end tests time out and end up ommitted.
Since models generally take longer, we can add the long running tag to keep them from timing out on CI
Reviewed By: cccclai
Differential Revision: D49279457