Skip to content

add flag for dynamic shapes to filter out static ops #3733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

mcr229
Copy link
Contributor

@mcr229 mcr229 commented May 24, 2024

Summary: Since we have updated XNNPACK to support almost 100% of dynamic shape ops, we can now create static_op lists which do not have any dynamic shape support and filter them out instead

Differential Revision: D57787384

Copy link

pytorch-bot bot commented May 24, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3733

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 3d35816 with merge base 9d4727d (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 24, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D57787384

mcr229 added a commit to mcr229/executorch that referenced this pull request May 24, 2024
Summary:

Since we have updated XNNPACK to support almost 100% of dynamic shape ops, we can now create static_op lists which do not have any dynamic shape support and filter them out instead

Differential Revision: D57787384
@mcr229 mcr229 force-pushed the export-D57787384 branch from fba7a2a to 5ca5282 Compare May 24, 2024 18:24
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D57787384

mcr229 added a commit to mcr229/executorch that referenced this pull request May 24, 2024
Summary:

Since we have updated XNNPACK to support almost 100% of dynamic shape ops, we can now create static_op lists which do not have any dynamic shape support and filter them out instead

Reviewed By: digantdesai

Differential Revision: D57787384
@mcr229 mcr229 force-pushed the export-D57787384 branch from 5ca5282 to 283b31b Compare May 24, 2024 19:57
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D57787384

Summary:

Since we have updated XNNPACK to support almost 100% of dynamic shape ops, we can now create static_op lists which do not have any dynamic shape support and filter them out instead

Reviewed By: digantdesai, kirklandsign

Differential Revision: D57787384
@mcr229 mcr229 force-pushed the export-D57787384 branch from 283b31b to 3d35816 Compare May 28, 2024 15:31
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D57787384

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 55d11e1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants