make builder accessible #3743
Closed
make builder accessible #3743
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3743
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 6847ed1 with merge base 9d4727d ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D57801568 |
wat3rBro
force-pushed
the
export-D57801568
branch
from
25e732e to
b38ea05
Compare
wat3rBro
pushed a commit
to wat3rBro/executorch
that referenced
this pull request
May 28, 2024
Summary: Make the `builder` accessible after calling `_export_llama`. Also add a member method to return most recent saved model path (which guarantee ending with `.pte`, so that user doesn't need to think about complicated logic to check if it's model name or file name). Reviewed By: cccclai Differential Revision: D57801568
|
This pull request was exported from Phabricator. Differential Revision: D57801568 |
Summary: Make the `builder` accessible after calling `_export_llama`. Also add a member method to return most recent saved model path (which guarantee ending with `.pte`, so that user doesn't need to think about complicated logic to check if it's model name or file name). Reviewed By: cccclai Differential Revision: D57801568
wat3rBro
force-pushed
the
export-D57801568
branch
from
b38ea05 to
6847ed1
Compare
|
This pull request was exported from Phabricator. Differential Revision: D57801568 |
cccclai
approved these changes
May 28, 2024
|
This pull request has been merged in 24b37f2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Make the
builderaccessible after calling_export_llama. Also add a member method to return most recent saved model path (which guarantee ending with.pte, so that user doesn't need to think about complicated logic to check if it's model name or file name).Reviewed By: cccclai
Differential Revision: D57801568