Rename SymShapeEval pass to HintBasedSymShapeEval pass and add warning for it. #377
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D49335965 |
ydwu4
force-pushed
the
export-D49335965
branch
from
ee20816 to
c40a6c8
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49335965 |
ydwu4
force-pushed
the
export-D49335965
branch
from
c40a6c8 to
ffa0958
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49335965 |
…g for it. (#377) Summary: As titled. The original SymShapeEvalPass doesn't respect user constraints and is based on hints of the symbolics. This diff changes its name to HintBasedSymShapeEval pass to make it clearer. Differential Revision: D49335965
ydwu4
force-pushed
the
export-D49335965
branch
from
ffa0958 to
24f2b8e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49335965 |
|
This pull request has been merged in a7e9dcf. |
Gasoonjia
pushed a commit
that referenced
this pull request
Jul 30, 2024
Do not import neither sentencepiece nor tiktoken until it is requested Same with HF hub
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: As titled. The original SymShapeEvalPass doesn't respect user constraints and is based on hints of the symbolics. This diff changes its name to HintBasedSymShapeEval pass to make it clearer.
Differential Revision: D49335965