[ET-SDK] Enable data_is_close for Half tensor #3790
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, if we use ET-SDK's `VerifyResultWithBundledExpectedOutput()` on `Half` tensors it will return true only if all elements are exactly equal. This change allows the common behavior to check that all elements are within the specified `rtol`/`atol`. Differential Revision: [D58018861](https://our.internmc.facebook.com/intern/diff/D58018861/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3790
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ No FailuresAs of commit 832c314 with merge base e650dd9 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D58018861 |
jorgep31415
added a commit
that referenced
this pull request
May 31, 2024
Currently, if we use ET-SDK's `VerifyResultWithBundledExpectedOutput()` on `Half` tensors it will return true only if all elements are exactly equal. This change allows the common behavior to check that all elements are within the specified `rtol`/`atol`. Differential Revision: [D58018861](https://our.internmc.facebook.com/intern/diff/D58018861/) ghstack-source-id: 228461841 Pull Request resolved: #3790
Currently, if we use ET-SDK's `VerifyResultWithBundledExpectedOutput()` on `Half` tensors it will return true only if all elements are exactly equal. This change allows the common behavior to check that all elements are within the specified `rtol`/`atol`. Differential Revision: [D58018861](https://our.internmc.facebook.com/intern/diff/D58018861/) [ghstack-poisoned]
jorgep31415
added a commit
that referenced
this pull request
May 31, 2024
Pull Request resolved: #3790 Currently, if we use ET-SDK's `VerifyResultWithBundledExpectedOutput()` on `Half` tensors it will return true only if all elements are exactly equal. This change allows the common behavior to check that all elements are within the specified `rtol`/`atol`. ghstack-source-id: 228467892 @exported-using-ghexport Differential Revision: [D58018861](https://our.internmc.facebook.com/intern/diff/D58018861/)
|
This pull request was exported from Phabricator. Differential Revision: D58018861 |
tarun292
approved these changes
Jun 3, 2024
|
This pull request has been merged in b9bbb71. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Currently, if we use ET-SDK's
VerifyResultWithBundledExpectedOutput()onHalftensors it will return true only if all elements are exactly equal.This change allows the common behavior to check that all elements are within the specified
rtol/atol.Differential Revision: D58018861