[ET-VK] Fix compute_graph_op_tests, attempt 2 #3805
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some reason, diff-time CI only executes tests on an Android 64-bit emulator, but continuous CI executes tests on both Android 64-bit and 32-bit emulators. The 32-bit emulator fails a few test cases, which we remove here. This is fine as they pass on our real target devices, and it's not worth figuring out the emulator's driver. Differential Revision: [D58090331](https://our.internmc.facebook.com/intern/diff/D58090331/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3805
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 57957ac with merge base 13ba3a7 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
jorgep31415
added a commit
that referenced
this pull request
Jun 3, 2024
For some reason, diff-time CI only executes tests on an Android 64-bit emulator, but continuous CI executes tests on both Android 64-bit and 32-bit emulators. The 32-bit emulator fails a few test cases, which we remove here. This is fine as they pass on our real target devices, and it's not worth figuring out the emulator's driver. Differential Revision: [D58090331](https://our.internmc.facebook.com/intern/diff/D58090331/) ghstack-source-id: 228672562 Pull Request resolved: #3805
|
This pull request was exported from Phabricator. Differential Revision: D58090331 |
yipjustin
approved these changes
Jun 3, 2024
|
This pull request has been merged in bb4f761. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
For some reason, diff-time CI only executes tests on an Android 64-bit emulator, but continuous CI executes tests on both Android 64-bit and 32-bit emulators.
The 32-bit emulator fails a few test cases, which we remove here. This is fine as they pass on our real target devices, and it's not worth figuring out the emulator's driver.
Differential Revision: D58090331