[executorch] Migrate ExecutorchModule.mm to use the new HierarchicalAllocator span ctor #391
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…llocator span ctor Stop using the deprecated HierarchicalAllocator ctor. Differential Revision: [D49344927](https://our.internmc.facebook.com/intern/diff/D49344927/) [ghstack-poisoned]
facebook-github-bot
added
the
CLA Signed
This was referenced Sep 17, 2023
dbort
added a commit
that referenced
this pull request
Sep 17, 2023
…llocator span ctor Stop using the deprecated HierarchicalAllocator ctor. Differential Revision: [D49344927](https://our.internmc.facebook.com/intern/diff/D49344927/) ghstack-source-id: 200970946 Pull Request resolved: #391
…erarchicalAllocator span ctor" Stop using the deprecated HierarchicalAllocator ctor. Differential Revision: [D49344927](https://our.internmc.facebook.com/intern/diff/D49344927/) [ghstack-poisoned]
dbort
added a commit
that referenced
this pull request
Sep 18, 2023
…llocator span ctor Pull Request resolved: #391 Stop using the deprecated HierarchicalAllocator ctor. ghstack-source-id: 201069203 @exported-using-ghexport Differential Revision: [D49344927](https://our.internmc.facebook.com/intern/diff/D49344927/)
…erarchicalAllocator span ctor" Stop using the deprecated HierarchicalAllocator ctor. Differential Revision: [D49344927](https://our.internmc.facebook.com/intern/diff/D49344927/) [ghstack-poisoned]
dbort
added a commit
that referenced
this pull request
Sep 18, 2023
…llocator span ctor Pull Request resolved: #391 Stop using the deprecated HierarchicalAllocator ctor. ghstack-source-id: 201071485 @exported-using-ghexport Differential Revision: [D49344927](https://our.internmc.facebook.com/intern/diff/D49344927/)
…erarchicalAllocator span ctor" Stop using the deprecated HierarchicalAllocator ctor. Differential Revision: [D49344927](https://our.internmc.facebook.com/intern/diff/D49344927/) [ghstack-poisoned]
This was referenced Sep 19, 2023
|
This pull request has been merged in dea872c. |
Gasoonjia
pushed a commit
that referenced
this pull request
Jul 30, 2024
Summary: In executorch this path was slower compared to using optimized ops. We did not debug that further, but for now just disabled it. Test Plan: CI Reviewers: Subscribers: Tasks: Tags:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Stop using the deprecated HierarchicalAllocator ctor.
Differential Revision: D49344927