Skip to content

end2end test for bundled program #395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

Gasoonjia
Copy link
Contributor

Summary:
Update pybinding functions to support bundled program (bp) APIs with method name. Split the end2end test for bp into a single test file.

The reasonsfor spliting are:

  1. Current overall end2end test does not support multiple methods, but we need to test bp on multiple methods.
  2. Bp does not need to be tested on several different kinds of program.
  3. Decompose the test for core ET and Bp.

Differential Revision: D49336485

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 18, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49336485

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49336485

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49336485

Songhao Jia and others added 3 commits September 19, 2023 16:33
Summary:
Pull Request resolved: pytorch/executorch#341

Update AOT api and schema to support multimethod by method name instead of method idx.

Since the following diffs will reformat the AOT apis, this diff doesn't pay much effort on documentation stuff.

Differential Revision: https://internalfb.com/D49246787

fbshipit-source-id: 7bb22ec26a69934b217730112077cff3009365a9
Differential Revision: https://internalfb.com/D49335926

fbshipit-source-id: 7a4e02914a7c09114327a3fda6572d8a8f92d310
Summary:
Pull Request resolved: pytorch/executorch#395

Update pybinding functions to support bundled program (bp) APIs with method name. Split the end2end test for bp into a single test file.

The reasonsfor spliting are:
1. Current overall end2end test does not support multiple methods, but we need to test bp on multiple methods.
2. Bp does not need to be tested on several different kinds of program.
3. Decompose the test for core ET and Bp.

Reviewed By: tarun292

Differential Revision: D49336485

fbshipit-source-id: ef1c4ef1d104e1c0c2e36cae706e1fc01fe20eb0
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49336485

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 0d58374.

Gasoonjia pushed a commit that referenced this pull request Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants