Improve static typing in tracer. #3973
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: X-link: pytorch/pytorch#128552 as title. Reviewed By: angelayi Differential Revision: D58485487
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3973
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit be45726 with merge base c67ce86 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D58485487 |
zhxchen17
added a commit
to zhxchen17/pytorch
that referenced
this pull request
Jun 13, 2024
Summary: X-link: pytorch/executorch#3973 Pull Request resolved: pytorch#128552 as title. Test Plan: CI Reviewed By: angelayi Differential Revision: D58485487
digantdesai
approved these changes
Jun 14, 2024
|
cc @freddan80 - the arm CI failure here seems like flaky test. Can we look into it? |
|
This pull request has been merged in 4b6331d. |
kirklandsign
added a commit
that referenced
this pull request
Jul 25, 2024
This reverts commit 4b6331d. PT pin not updated to this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
X-link: pytorch/pytorch#128552
as title.
Reviewed By: angelayi
Differential Revision: D58485487