make the predicate truly data dependent. #4130
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/4130
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 6d38493 with merge base b91c20b ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D59287189 |
|
This pull request was exported from Phabricator. Differential Revision: D59287189 |
ydwu4
added a commit
to ydwu4/executorch-1
that referenced
this pull request
Jul 8, 2024
Summary: Pull Request resolved: pytorch#4130 Make the pred truely data-dependent to avoid specializing into one of the branches if we land pytorch/pytorch#128709. Reviewed By: angelayi Differential Revision: D59287189
Summary: Pull Request resolved: pytorch#4130 Make the pred truely data-dependent to avoid specializing into one of the branches if we land pytorch/pytorch#128709. Reviewed By: angelayi Differential Revision: D59287189
|
This pull request was exported from Phabricator. Differential Revision: D59287189 |
angelayi
approved these changes
Jul 8, 2024
|
This pull request has been merged in 5f2ab0e. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Make the pred truely data-dependent to avoid specializing into one of the branches if we land pytorch/pytorch#128709.
Differential Revision: D59287189