-
Notifications
You must be signed in to change notification settings - Fork 608
add mps stories end to end in ci #4137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/4137
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 1ed3c86 with merge base 970e278 ( BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
@cccclai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
1 similar comment
@cccclai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
@@ -142,6 +151,9 @@ fi | |||
if [[ "${QE}" == "ON" ]]; then | |||
EXPORT_ARGS="${EXPORT_ARGS} --embedding-quantize 8,1024" | |||
fi | |||
if [[ "${MPS}" == "ON" ]]; then | |||
EXPORT_ARGS="${EXPORT_ARGS} -kv -v --mps --disable_dynamic_shape" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am thinking of flipping this to explicitly op-in for dynamic_shape due to incrase in memory footprint
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😅
@cccclai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
@cccclai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Summary: Add the end to end test for stories fp32 in ci Pull Request resolved: pytorch#4137 Reviewed By: kimishpatel Differential Revision: D59305037 Pulled By: cccclai fbshipit-source-id: 9c132721e1120c00f4cb969b02d494879e181f32
@DenisVieriu97 just fyi we're adding mps backend to the CI job |
Add the end to end test for stories fp32 in ci