Rewrite etdump debug data value comparision #4152
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/4152
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit f528ee2 with merge base 00bea84 ( BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D59350018 |
|
This pull request was exported from Phabricator. Differential Revision: D59350018 |
Olivia-liu
force-pushed
the
export-D59350018
branch
from
2248ebe to
c4e7397
Compare
Olivia-liu
added a commit
to Olivia-liu/executorch-1
that referenced
this pull request
Jul 8, 2024
Summary: Pull Request resolved: pytorch#4152 The original comparison actually compares the metadata of 2 tensors, not the tensors themselves, and would fail when the 2 tensors are written at different locations in the buffer (because of different [offsets](https://www.internalfb.com/code/fbsource/[02da17b6e421d91ada2fd690e9f9ecfdb4bedfc1]/fbcode/executorch/sdk/etdump/schema_flatcc.py?lines=26)), even if their values are the same. Therefore, change to the new compaision logic which compares the actual values. Differential Revision: D59350018
|
This pull request was exported from Phabricator. Differential Revision: D59350018 |
Olivia-liu
added a commit
to Olivia-liu/executorch-1
that referenced
this pull request
Jul 8, 2024
Summary: Pull Request resolved: pytorch#4152 The original comparison actually compares the metadata of 2 tensors, not the tensors themselves, and would fail when the 2 tensors are written at different locations in the buffer (because of different [offsets](https://www.internalfb.com/code/fbsource/[02da17b6e421d91ada2fd690e9f9ecfdb4bedfc1]/fbcode/executorch/sdk/etdump/schema_flatcc.py?lines=26)), even if their values are the same. Therefore, change to the new compaision logic which compares the actual values. Differential Revision: D59350018
Olivia-liu
force-pushed
the
export-D59350018
branch
from
c4e7397 to
7aa39b4
Compare
|
This pull request was exported from Phabricator. Differential Revision: D59350018 |
Olivia-liu
force-pushed
the
export-D59350018
branch
from
7aa39b4 to
f1e79e4
Compare
Olivia-liu
added a commit
to Olivia-liu/executorch-1
that referenced
this pull request
Jul 9, 2024
Summary: Pull Request resolved: pytorch#4152 The original comparison actually compares the metadata of 2 tensors, not the tensors themselves, and would fail when the 2 tensors are written at different locations in the buffer (because of different [offsets](https://www.internalfb.com/code/fbsource/[02da17b6e421d91ada2fd690e9f9ecfdb4bedfc1]/fbcode/executorch/sdk/etdump/schema_flatcc.py?lines=26)), even if their values are the same. Therefore, change to the new comparison logic which compares the actual values. Differential Revision: D59350018
dbort
approved these changes
Jul 9, 2024
Summary: Pull Request resolved: pytorch#4152 The original comparison actually compares the metadata of 2 tensors, not the tensors themselves, and would fail when the 2 tensors are written at different locations in the buffer (because of different [offsets](https://www.internalfb.com/code/fbsource/[02da17b6e421d91ada2fd690e9f9ecfdb4bedfc1]/fbcode/executorch/sdk/etdump/schema_flatcc.py?lines=26)), even if their values are the same. Therefore, change to the new comparison logic which compares the actual values. Reviewed By: dbort Differential Revision: D59350018
|
This pull request was exported from Phabricator. Differential Revision: D59350018 |
Olivia-liu
force-pushed
the
export-D59350018
branch
from
f1e79e4 to
f528ee2
Compare
|
This pull request has been merged in 561c035. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: The original comparison actually compares the metadata of 2 tensors, not the tensors themselves, and would fail when the 2 tensors are written at different locations in the buffer (because of different offsets), even if their values are the same. Therefore, change to the new compaision logic which compares the actual values.
Differential Revision: D59350018