Skip to content

Fix OSS CI macos test-custom-ops-macos #4170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Fix OSS CI macos test-custom-ops-macos #4170

wants to merge 3 commits into from

Conversation

kirklandsign
Copy link
Contributor

No description provided.

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jul 8, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/4170

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 89525f6 with merge base a33936b (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 8, 2024
@kirklandsign
Copy link
Contributor Author

Got error https://productionresultssa1.blob.core.windows.net/actions-results/89456ed1-b839-4e2b-975a-f3b989fcd7b9/workflow-job-run-ca7d7c50-4682-5db1-d3ca-b614f46f4c5f/logs/job/job-logs.txt?rsct=text%2Fplain&se=2024-07-08T21%3A28%3A25Z&sig=DAj0M5KXQ%2FGO4fTaaJAzu2NQKvRCTvHM5jgeFU%2FwuJs%3D&ske=2024-07-09T05%3A30%3A49Z&skoid=ca7593d4-ee42-46cd-af88-8b886a2f84eb&sks=b&skt=2024-07-08T17%3A30%3A49Z&sktid=398a6654-997b-47e9-b12b-9515b896b4de&skv=2023-11-03&sp=r&spr=https&sr=b&st=2024-07-08T21%3A18%3A20Z&sv=2023-11-03

2024-07-08T21:17:39.6493720Z make[2]: *** No rule to make target `LIB_executorch_no_prim_ops_shared-NOTFOUND', needed by `libcustom_ops_aot_lib.dylib'.  Stop.
2024-07-08T21:17:39.6494290Z make[2]: *** Waiting for unfinished jobs....

@kirklandsign
Copy link
Contributor Author 

Exporting custom_ops_2.pte
No registered custom op my_ops::mul4.out
Traceback (most recent call last):
  File "/Users/hsz/miniconda3/lib/python3.10/runpy.py", line 196, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "/Users/hsz/miniconda3/lib/python3.10/runpy.py", line 86, in _run_code
    exec(code, run_globals)
  File "/Users/hsz/executorch/examples/portable/custom_ops/custom_ops_2.py", line 56, in <module>
    torch.ops.load_library(args.so_library)
  File "/Users/hsz/miniconda3/lib/python3.10/site-packages/torch/_ops.py", line 1048, in load_library
    ctypes.CDLL(path)
  File "/Users/hsz/miniconda3/lib/python3.10/ctypes/__init__.py", line 374, in __init__
    self._handle = _dlopen(self._name, mode)
OSError: dlopen(/Users/hsz/executorch/cmake-out/examples/portable/custom_ops/libcustom_ops_aot_lib.dylib, 0x0006): Library not loaded: @rpath/libexecutorch_no_prim_ops_shared.dylib
  Referenced from: <18EEFCB1-471E-3C05-9F11-BE9D8A7BB703> /Users/hsz/executorch/cmake-out/examples/portable/custom_ops/libcustom_ops_aot_lib.dylib
  Reason: tried: '/Users/hsz/miniconda3/lib/python3.10/site-packages/torch/lib/libexecutorch_no_prim_ops_shared.dylib' (no such file), '/System/Volumes/Preboot/Cryptexes/OS/Users/hsz/miniconda3/lib/python3.10/site-packages/torch/lib/libexecutorch_no_prim_ops_shared.dylib' (no such file), '/Users/hsz/miniconda3/lib/python3.10/site-packages/torch/lib/libexecutorch_no_prim_ops_shared.dylib' (no such file), '/System/Volumes/Preboot/Cryptexes/OS/Users/hsz/miniconda3/lib/python3.10/site-packages/torch/lib/libexecutorch_no_prim_ops_shared.dylib' (no such file), '/Users/hsz/miniconda3/lib/python3.10/lib-dynload/../../libexecutorch_no_prim_ops_shared.dylib' (no such file), '/Users/hsz/miniconda3/bin/../lib/libexecutorch_no_prim_ops_shared.dylib' (no such file)

@kirklandsign kirklandsign requested a review from larryliu0820 July 8, 2024 22:22
@facebook-github-bot
Copy link
Contributor

@kirklandsign has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

larryliu0820
larryliu0820 reviewed Jul 8, 2024
View reviewed changes
examples/portable/custom_ops/test_custom_ops.sh
@@ -103,7 +103,7 @@ test_cmake_custom_op_2() {

EXT=$(get_shared_lib_ext)
echo "Exporting ${model_name}.pte"
${PYTHON_EXECUTABLE} -m "examples.portable.custom_ops.${model_name}" --so_library="cmake-out/examples/portable/custom_ops/libcustom_ops_aot_lib$EXT"
DYLD_LIBRARY_PATH="cmake-out/lib" ${PYTHON_EXECUTABLE} -m "examples.portable.custom_ops.${model_name}" --so_library="cmake-out/examples/portable/custom_ops/libcustom_ops_aot_lib$EXT"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this necessary?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/pytorch/executorch/actions/runs/9847259938/job/27186835771 can’t find dl path

@facebook-github-bot
Copy link
Contributor

@kirklandsign merged this pull request in 3521021.

@kirklandsign kirklandsign deleted the fix-oss-ci branch September 6, 2024 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@larryliu0820 larryliu0820 larryliu0820 approved these changes

Assignees
No one assigned
Labels
ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kirklandsign @facebook-github-bot @larryliu0820