Skip to content

Let Module use FIleDataLoader when requested. #4174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Let Module use FIleDataLoader when requested. #4174

wants to merge 1 commit into from

Conversation

shoumikhin
Copy link
Contributor

Summary: Hide more data loader options behind the facade.

Differential Revision: D59498348

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jul 8, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/4174

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 2 Unrelated Failures

As of commit 50e94c7 with merge base 561c035 (image):

NEW FAILURE - The following job has failed:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

UNSTABLE - The following job failed but was likely due to flakiness present on trunk and has been marked as unstable:

  • Android / test-llama-app / mobile-job (android) (gh) (#3344)
    Could not assume role with user credentials: User: arn:aws:sts::308535385114:assumed-role/gh-ci-github-action-runners-runner-role/i-0cfce0cf521a06310 is not authorized to perform: sts:TagSession on resource: arn:aws:iam::308535385114:role/gha_workflow_mobile_job

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 8, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D59498348

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D59498348

3 similar comments
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D59498348

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D59498348

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D59498348

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D59498348

3 similar comments
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D59498348

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D59498348

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D59498348

@shoumikhin @facebook-github-bot
Let Module use FIleDataLoader when requested. (#4174)
50e94c7 
Summary:
Pull Request resolved: #4174

Hide more data loader options behind the facade.

Reviewed By: kirklandsign

Differential Revision: D59498348
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D59498348

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in c96c205.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shoumikhin @facebook-github-bot @cccclai