[ET-VK] Convert DeviceHandle into a struct
#4186
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We already expose the only private member `VkDevice` from Adapter's public function `device_handle()` so nothing's really private. This change also makes it consistent with the layout of `PhysicalDevice` and allows decoupling from Adapter in the next change. Differential Revision: [D59540129](https://our.internmc.facebook.com/intern/diff/D59540129/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/4186
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit d23f91d with merge base bdbfcc6 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D59540129 |
This was referenced Jul 9, 2024
SS-JIA
approved these changes
Jul 9, 2024
|
This pull request has been merged in 81cf3ab. |
kedarnath03
pushed a commit
to kedarnath03/executorch
that referenced
this pull request
Jun 25, 2025
We already expose the only private member `VkDevice` from Adapter's public function `device_handle()` so nothing's really private. This change also makes it consistent with the layout of `PhysicalDevice` and allows decoupling from Adapter in the next change. Differential Revision: [D59540129](https://our.internmc.facebook.com/intern/diff/D59540129/) ghstack-source-id: 233085716 Pull Request resolved: pytorch/executorch#4186
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
PhysicalDevice/DeviceHandlefromAdapter.*#4187DeviceHandleinto a struct #4186RuntimeConfigurationtoRuntimeConfig#4182containers/folder inapi/#4181GPUMemoryLayoutandStorageTypetoutils/#4180utils/andvk_apiout ofapi/#4179We already expose the only private member
VkDevicefrom Adapter's public functiondevice_handle()so nothing's really private. This change also makes it consistent with the layout ofPhysicalDeviceand allows decoupling from Adapter in the next change.Differential Revision: D59540129