Bug fix to disable lower recomposed sdpa #4211
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/4211
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ No FailuresAs of commit 31b3a85 with merge base 63e8025 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
@guangy10 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
guangy10
force-pushed
the
bug_fix_xnnpack_partitioner
branch
from
7900b4a to
31b3a85
Compare
|
Fix linter |
|
@guangy10 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
digantdesai
reviewed
Jul 11, 2024
| @@ -869,7 +869,9 @@ def __init__( | |||
| self.quant = quant | |||
|
|
|||
| # TODO(T174256335) - remove this once we have a better way to handle >2d Mask | |||
| self._lower_recomposed_sdpa: bool = _lower_recomposed_sdpa or True | |||
| self._lower_recomposed_sdpa: bool = ( | |||
| _lower_recomposed_sdpa if _lower_recomposed_sdpa is not None else True | |||
There was a problem hiding this comment.
I never tested the False case ;)
digantdesai
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.