Skip to content

Program.fbs change to support serialized mutable state #4216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

JacobSzwejbka
Copy link
Contributor

Summary: Need a way to indicate values that have a meaningful initial state serialized in the program, who also are able to be mutated on device.

Differential Revision: D58747605

Copy link

pytorch-bot bot commented Jul 11, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/4216

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 5c99361 with merge base b7c8378 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 11, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D58747605

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D58747605

JacobSzwejbka added a commit to JacobSzwejbka/executorch-1 that referenced this pull request Jul 11, 2024
Summary:
Pull Request resolved: pytorch#4216

Need a way to indicate values that have a meaningful initial state serialized in the program, who also are able to be mutated on device.

Differential Revision: D58747605
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D58747605

JacobSzwejbka added a commit to JacobSzwejbka/executorch-1 that referenced this pull request Jul 11, 2024
Summary:
Pull Request resolved: pytorch#4216

Need a way to indicate values that have a meaningful initial state serialized in the program, who also are able to be mutated on device.

Differential Revision: D58747605
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D58747605

JacobSzwejbka added a commit to JacobSzwejbka/executorch-1 that referenced this pull request Jul 11, 2024
Summary:
Pull Request resolved: pytorch#4216

Need a way to indicate values that have a meaningful initial state serialized in the program, who also are able to be mutated on device.

Differential Revision: D58747605
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D58747605

JacobSzwejbka added a commit to JacobSzwejbka/executorch-1 that referenced this pull request Jul 15, 2024
Summary:
Pull Request resolved: pytorch#4216

Need a way to indicate values that have a meaningful initial state serialized in the program, who also are able to be mutated on device.

Differential Revision: D58747605
JacobSzwejbka added a commit to JacobSzwejbka/executorch-1 that referenced this pull request Jul 18, 2024
Summary:
Pull Request resolved: pytorch#4216

Need a way to indicate values that have a meaningful initial state serialized in the program, who also are able to be mutated on device.

Differential Revision: D58747605
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D58747605

JacobSzwejbka added a commit to JacobSzwejbka/executorch-1 that referenced this pull request Jul 19, 2024
Summary:
Pull Request resolved: pytorch#4216

Need a way to indicate values that have a meaningful initial state serialized in the program, who also are able to be mutated on device.

https://docs.google.com/document/d/1D8WpMmIiQxU_n5OYWXl3mrpBYUewz79izyAO2UknSsM/edit?usp=sharing

Differential Revision: D58747605
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D58747605

JacobSzwejbka added a commit to JacobSzwejbka/executorch-1 that referenced this pull request Jul 19, 2024
Summary:
Pull Request resolved: pytorch#4216

Need a way to indicate values that have a meaningful initial state serialized in the program, who also are able to be mutated on device.

https://docs.google.com/document/d/1D8WpMmIiQxU_n5OYWXl3mrpBYUewz79izyAO2UknSsM/edit?usp=sharing

Differential Revision: D58747605
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D58747605

JacobSzwejbka added a commit to JacobSzwejbka/executorch-1 that referenced this pull request Jul 19, 2024
Summary:
Pull Request resolved: pytorch#4216

Need a way to indicate values that have a meaningful initial state serialized in the program, who also are able to be mutated on device.

https://docs.google.com/document/d/1D8WpMmIiQxU_n5OYWXl3mrpBYUewz79izyAO2UknSsM/edit?usp=sharing

Differential Revision: D58747605
@JacobSzwejbka JacobSzwejbka force-pushed the export-D58747605 branch 2 times, most recently from 8bb3ec1 to 197cf6c Compare July 19, 2024 18:47
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D58747605

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D58747605

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D58747605

JacobSzwejbka added a commit to JacobSzwejbka/executorch-1 that referenced this pull request Jul 24, 2024
Summary:
Pull Request resolved: pytorch#4216

Need a way to indicate values that have a meaningful initial state serialized in the program, who also are able to be mutated on device.

https://docs.google.com/document/d/1D8WpMmIiQxU_n5OYWXl3mrpBYUewz79izyAO2UknSsM/edit?usp=sharing

Differential Revision: D58747605
JacobSzwejbka added a commit to JacobSzwejbka/executorch-1 that referenced this pull request Jul 24, 2024
Summary:
Pull Request resolved: pytorch#4216

Need a way to indicate values that have a meaningful initial state serialized in the program, who also are able to be mutated on device.

https://docs.google.com/document/d/1D8WpMmIiQxU_n5OYWXl3mrpBYUewz79izyAO2UknSsM/edit?usp=sharing

Differential Revision: D58747605
JacobSzwejbka added a commit to JacobSzwejbka/executorch-1 that referenced this pull request Jul 25, 2024
Summary:
Pull Request resolved: pytorch#4216

Need a way to indicate values that have a meaningful initial state serialized in the program, who also are able to be mutated on device.

https://docs.google.com/document/d/1D8WpMmIiQxU_n5OYWXl3mrpBYUewz79izyAO2UknSsM/edit?usp=sharing

Differential Revision: D58747605
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D58747605

JacobSzwejbka added a commit to JacobSzwejbka/executorch-1 that referenced this pull request Jul 25, 2024
Summary:
Pull Request resolved: pytorch#4216

Need a way to indicate values that have a meaningful initial state serialized in the program, who also are able to be mutated on device.

https://docs.google.com/document/d/1D8WpMmIiQxU_n5OYWXl3mrpBYUewz79izyAO2UknSsM/edit?usp=sharing

Differential Revision: D58747605
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D58747605

JacobSzwejbka added a commit to JacobSzwejbka/executorch-1 that referenced this pull request Jul 25, 2024
Summary:
Pull Request resolved: pytorch#4216

Need a way to indicate values that have a meaningful initial state serialized in the program, who also are able to be mutated on device.

https://docs.google.com/document/d/1D8WpMmIiQxU_n5OYWXl3mrpBYUewz79izyAO2UknSsM/edit?usp=sharing

Differential Revision: D58747605
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D58747605

JacobSzwejbka added a commit to JacobSzwejbka/executorch-1 that referenced this pull request Jul 29, 2024
Summary:
Pull Request resolved: pytorch#4216

Need a way to indicate values that have a meaningful initial state serialized in the program, who also are able to be mutated on device.

https://docs.google.com/document/d/1D8WpMmIiQxU_n5OYWXl3mrpBYUewz79izyAO2UknSsM/edit?usp=sharing

Differential Revision: D58747605
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D58747605

JacobSzwejbka added a commit to JacobSzwejbka/executorch-1 that referenced this pull request Jul 30, 2024
Summary:
Pull Request resolved: pytorch#4216

Need a way to indicate values that have a meaningful initial state serialized in the program, who also are able to be mutated on device.

https://docs.google.com/document/d/1D8WpMmIiQxU_n5OYWXl3mrpBYUewz79izyAO2UknSsM/edit?usp=sharing

Reviewed By: dbort

Differential Revision: D58747605
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D58747605

JacobSzwejbka added a commit to JacobSzwejbka/executorch-1 that referenced this pull request Jul 30, 2024
Summary:
Pull Request resolved: pytorch#4216

Need a way to indicate values that have a meaningful initial state serialized in the program, who also are able to be mutated on device.

https://docs.google.com/document/d/1D8WpMmIiQxU_n5OYWXl3mrpBYUewz79izyAO2UknSsM/edit?usp=sharing

Reviewed By: dbort

Differential Revision: D58747605
JacobSzwejbka added a commit to JacobSzwejbka/executorch-1 that referenced this pull request Jul 30, 2024
Summary:
Pull Request resolved: pytorch#4216

Need a way to indicate values that have a meaningful initial state serialized in the program, who also are able to be mutated on device.

https://docs.google.com/document/d/1D8WpMmIiQxU_n5OYWXl3mrpBYUewz79izyAO2UknSsM/edit?usp=sharing

Differential Revision: D58747605
Summary:
Pull Request resolved: pytorch#4216

Need a way to indicate values that have a meaningful initial state serialized in the program, who also are able to be mutated on device.

https://docs.google.com/document/d/1D8WpMmIiQxU_n5OYWXl3mrpBYUewz79izyAO2UknSsM/edit?usp=sharing

Reviewed By: dbort

Differential Revision: D58747605
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D58747605

JacobSzwejbka added a commit to JacobSzwejbka/executorch-1 that referenced this pull request Jul 30, 2024
Summary:
Pull Request resolved: pytorch#4216

Need a way to indicate values that have a meaningful initial state serialized in the program, who also are able to be mutated on device.

https://docs.google.com/document/d/1D8WpMmIiQxU_n5OYWXl3mrpBYUewz79izyAO2UknSsM/edit?usp=sharing

Differential Revision: D58747605

Reviewed By: dbort
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 2f8ecf3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants