Remove print statement in SPIR-V compilation scripts #4268
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Remove print statements in SPIR-V compilation script to fix CI errors. Differential Revision: D59768872
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/4268
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ No FailuresAs of commit 504bdbe with merge base d3c92de ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D59768872 |
jorgep31415
approved these changes
Jul 15, 2024
|
This pull request has been merged in 09fc6d8. |
huydhn
pushed a commit
to pytorch/test-infra
that referenced
this pull request
Jul 23, 2024
See: https://fb.workplace.com/groups/4571909969591489/permalink/7818394354943018/ ExecuTorch CI was running into an issue where non-utf8 print output caused tests to crash. This was resolved by removing the printing in pytorch/executorch#4268. This PR updates the error handling to use `backslashreplace`, which should still show us the error/printing, but without crashing the test. From https://docs.python.org/3.9/library/io.html#io.TextIOWrapper: ``` 'backslashreplace' causes malformed data to be replaced by a backslashed escape sequence. ``` From https://docs.python.org/3/library/subprocess.html#frequently-used-arguments: If encoding or errors are specified, or text (also known as universal_newlines) is true, the file objects stdin, stdout and stderr will be opened in text mode using the encoding and errors specified in the call or the defaults for [io.TextIOWrapper](https://docs.python.org/3/library/io.html#io.TextIOWrapper).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Remove print statements in SPIR-V compilation script to fix CI errors.
Differential Revision: D59768872