Use external_deps for sentencepiece #4269
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as title Differential Revision: [D59770172](https://our.internmc.facebook.com/intern/diff/D59770172/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/4269
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 9acab8c with merge base 0cde6b8 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
This was referenced Jul 15, 2024
|
This pull request was exported from Phabricator. Differential Revision: D59770172 |
helunwencser
added a commit
that referenced
this pull request
Jul 15, 2024
as title Differential Revision: [D59770172](https://our.internmc.facebook.com/intern/diff/D59770172/) ghstack-source-id: 233802575 Pull Request resolved: #4269
as title Differential Revision: [D59770172](https://our.internmc.facebook.com/intern/diff/D59770172/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D59770172 |
helunwencser
added a commit
that referenced
this pull request
Jul 15, 2024
Pull Request resolved: #4269 as title Differential Revision: [D59770172](https://our.internmc.facebook.com/intern/diff/D59770172/) ghstack-source-id: 233819058
as title Differential Revision: [D59770172](https://our.internmc.facebook.com/intern/diff/D59770172/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D59770172 |
as title Differential Revision: [D59770172](https://our.internmc.facebook.com/intern/diff/D59770172/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D59770172 |
as title Differential Revision: [D59770172](https://our.internmc.facebook.com/intern/diff/D59770172/) [ghstack-poisoned]
helunwencser
added a commit
that referenced
this pull request
Jul 17, 2024
Pull Request resolved: #4269 as title ghstack-source-id: 234090425 Differential Revision: [D59770172](https://our.internmc.facebook.com/intern/diff/D59770172/)
|
This pull request was exported from Phabricator. Differential Revision: D59770172 |
dbort
approved these changes
Jul 17, 2024
|
This pull request has been merged in 8950d90. |
kedarnath03
pushed a commit
to kedarnath03/executorch
that referenced
this pull request
Jun 25, 2025
Pull Request resolved: pytorch/executorch#4269 as title ghstack-source-id: 233843177 Differential Revision: [D59770172](https://our.internmc.facebook.com/intern/diff/D59770172/)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
as title
Differential Revision: D59770172