Skip to content

Update Hugging Face packages to latest versions #4306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

guangy10
Copy link
Contributor

No description provided.

@guangy10 guangy10 requested review from dbort and kirklandsign July 18, 2024 21:45
Copy link

pytorch-bot bot commented Jul 18, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/4306

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 22c7a31 with merge base 0333390 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 18, 2024
@guangy10
Copy link
Contributor Author

Looking into the llava export failure.

@guangy10 guangy10 force-pushed the update_hf_versions branch from 930162e to 22c7a31 Compare July 19, 2024 18:08
Comment on lines +28 to +31

# Newer transformer will give TypeError: LlavaLlamaForCausalLM.forward() got an unexpected keyword argument 'cache_position'
pip install timm==0.6.13
pip install transformers==4.38.2
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Idk how it could work in the past, but the HF packages must be restored to the llava compatible version AFTER running the install_requirements.sh.

@guangy10 guangy10 requested a review from larryliu0820 July 19, 2024 19:24
@facebook-github-bot
Copy link
Contributor

@guangy10 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@guangy10 merged this pull request in 5865a57.

@guangy10 guangy10 deleted the update_hf_versions branch August 21, 2024 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants