Skip to content

Qualcomm AI Engine Direct - Refactor & centralize common keywords #4357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Qualcomm AI Engine Direct - Refactor & centralize common keywords #4357

wants to merge 1 commit into from

Conversation

chuntl
Copy link
Contributor

@chuntl chuntl commented Jul 23, 2024

Summary:

  • Summarize the QCOM specific keywords
  • Replace with the hard code part in qualcomm code base

@chuntl
Qualcomm AI Engine Direct - Refactor & centralize common keywords
a18e0c7 
Summary:
- Summarize the QCOM specific keywords
- Replace with the hard code part in qualcomm code base
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jul 23, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/4357

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit a18e0c7 with merge base 8bdafb0 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 23, 2024
@chuntl
Copy link
Contributor Author

chuntl commented Jul 23, 2024

Hi @cccclai ,

This PR is used to centralize the qualcomm specific keywords.
May I know if you could help to review and merge it, thank you!

BR,
chuntl

cccclai
cccclai approved these changes Jul 23, 2024
View reviewed changes
backends/qualcomm/utils/constants.py

# Qualcomm specific key

# constants in backends/qualcomm/passes & backends/qualcomm/builders
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for centralize the constant lists! Definitely easier to scale

@facebook-github-bot
Copy link
Contributor

@cccclai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@cccclai merged this pull request in 56120f9.

This was referenced Jul 24, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cccclai cccclai cccclai approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chuntl @facebook-github-bot @cccclai