Skip to content

Implement mm op for Arm backend #4628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 15, 2024
Merged

Conversation

tom-arm
Copy link
Collaborator

@tom-arm tom-arm commented Aug 9, 2024

  • Add legalization from aten.mm to TOSA MatMul for FP32 & INT8 types
  • Add tests for main and base inference
  • Add an annotator for aten.mm in the quantizer

* Add legalization from aten.mm to TOSA MatMul for FP32 & INT8 types
* Add tests for main and base inference
* Add an annotator for aten.mm in the quantizer

Signed-off-by: Tom Allsop <[email protected]>
Change-Id: I4b2af1a1e4c9e1bd2949e634fa5e711d6f8a3cdd
Copy link

pytorch-bot bot commented Aug 9, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/4628

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 1825718 with merge base 5d151d0 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 9, 2024
@tom-arm
Copy link
Collaborator Author

tom-arm commented Aug 9, 2024

@pytorchbot label 'partner: arm'

@pytorch-bot pytorch-bot bot added the partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm label Aug 9, 2024
@tom-arm
Copy link
Collaborator Author

tom-arm commented Aug 12, 2024

@pytorchbot label 'ciflow/trunk'

Copy link

pytorch-bot bot commented Aug 12, 2024

Can't add following labels to PR: ciflow/trunk. Please ping one of the reviewers for help.

Copy link
Contributor

@digantdesai digantdesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@facebook-github-bot
Copy link
Contributor

@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot facebook-github-bot merged commit 48b4304 into pytorch:main Aug 15, 2024
35 of 36 checks passed
kirklandsign pushed a commit to kirklandsign/executorch that referenced this pull request Aug 15, 2024
Differential Revision: D61240788

Pull Request resolved: pytorch#4628
@tom-arm tom-arm deleted the add_bmm_op branch August 19, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants