Make seq_len param available in JNI layer generate() #4745
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/4745
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 2662099 with merge base 5c9a00a ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D61343892 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D61343892 |
Riandy
added a commit
to Riandy/executorch
that referenced
this pull request
Aug 16, 2024
Summary: Pull Request resolved: pytorch#4745 - Previously, on JNI side, we fixed the seq_len to 128. - In this diff, we expose seq_len as a paramter in generate(), so devs can customize this as needed Reviewed By: kirklandsign Differential Revision: D61343892
Riandy
force-pushed
the
export-D61343892
branch
from
344f4c9 to
bf410ec
Compare
cmodi-meta
approved these changes
Aug 16, 2024
kirklandsign
approved these changes
Aug 16, 2024
Summary: Pull Request resolved: pytorch#4745 - Previously, on JNI side, we fixed the seq_len to 128. - In this diff, we expose seq_len as a paramter in generate(), so devs can customize this as needed Reviewed By: kirklandsign Differential Revision: D61343892
|
This pull request was exported from Phabricator. Differential Revision: D61343892 |
Riandy
force-pushed
the
export-D61343892
branch
from
bf410ec to
2662099
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Reviewed By: kirklandsign
Differential Revision: D61343892