-
Notifications
You must be signed in to change notification settings - Fork 607
Update fused kernels and call _safe_softmax from SDPA #4772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/4772
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (30 Unrelated Failures)As of commit 388a062 with merge base 6cb5726 ( FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This pull request was exported from Phabricator. Differential Revision: D61418679 |
This pull request was exported from Phabricator. Differential Revision: D61418679 |
Summary: Pull Request resolved: pytorch#4772 X-link: pytorch/pytorch#131863 cc ezyang gchanan jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10 Valentine233 imported-using-ghimport Test Plan: Imported from OSS Reviewed By: Chillee Differential Revision: D61418679 Pulled By: drisspg
699f6bb
to
27a4a02
Compare
This pull request was exported from Phabricator. Differential Revision: D61418679 |
Summary: Pull Request resolved: pytorch#4772 X-link: pytorch/pytorch#131863 cc ezyang gchanan jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10 Valentine233 imported-using-ghimport Test Plan: Imported from OSS Reviewed By: Chillee Differential Revision: D61418679 Pulled By: drisspg
27a4a02
to
3a49525
Compare
This pull request was exported from Phabricator. Differential Revision: D61418679 |
3a49525
to
30eef3d
Compare
Summary: Pull Request resolved: pytorch#4772 X-link: pytorch/pytorch#131863 cc ezyang gchanan jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10 Valentine233 imported-using-ghimport Test Plan: Imported from OSS Reviewed By: Chillee Differential Revision: D61418679 Pulled By: drisspg
@YifanShenSZ ptal when you have a chance! |
Summary: Pull Request resolved: pytorch#4772 X-link: pytorch/pytorch#131863 cc ezyang gchanan jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10 Valentine233 imported-using-ghimport Test Plan: Imported from OSS Reviewed By: Chillee Differential Revision: D61418679 Pulled By: drisspg
30eef3d
to
388a062
Compare
This pull request was exported from Phabricator. Differential Revision: D61418679 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome safe softmax 🎊 & thanks for the subsequent fix in executorch 🙏
@shoumikhin not totally sure what to do about how red executorch trunk is on this one |
Summary:
X-link: pytorch/pytorch#131863
cc ezyang gchanan jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10 Valentine233
imported-using-ghimport
Reviewed By: Chillee
Differential Revision: D61418679
Pulled By: drisspg