Skip to content

Update fused kernels and call _safe_softmax from SDPA #4772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

drisspg
Copy link
Contributor

@drisspg drisspg commented Aug 17, 2024

Summary:
X-link: pytorch/pytorch#131863

cc ezyang gchanan jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10 Valentine233

imported-using-ghimport

Reviewed By: Chillee

Differential Revision: D61418679

Pulled By: drisspg

Copy link

pytorch-bot bot commented Aug 17, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/4772

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (30 Unrelated Failures)

As of commit 388a062 with merge base 6cb5726 (image):

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 17, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D61418679

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D61418679

drisspg added a commit to drisspg/executorch that referenced this pull request Aug 17, 2024
Summary:
Pull Request resolved: pytorch#4772

X-link: pytorch/pytorch#131863

cc ezyang gchanan jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10 Valentine233

imported-using-ghimport

Test Plan: Imported from OSS

Reviewed By: Chillee

Differential Revision: D61418679

Pulled By: drisspg
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D61418679

drisspg added a commit to drisspg/executorch that referenced this pull request Aug 17, 2024
Summary:
Pull Request resolved: pytorch#4772

X-link: pytorch/pytorch#131863

cc ezyang gchanan jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10 Valentine233

imported-using-ghimport

Test Plan: Imported from OSS

Reviewed By: Chillee

Differential Revision: D61418679

Pulled By: drisspg
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D61418679

drisspg added a commit to drisspg/executorch that referenced this pull request Aug 17, 2024
Summary:
Pull Request resolved: pytorch#4772

X-link: pytorch/pytorch#131863

cc ezyang gchanan jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10 Valentine233

imported-using-ghimport

Test Plan: Imported from OSS

Reviewed By: Chillee

Differential Revision: D61418679

Pulled By: drisspg
@shoumikhin
Copy link
Contributor

@YifanShenSZ ptal when you have a chance!

Summary:
Pull Request resolved: pytorch#4772

X-link: pytorch/pytorch#131863

cc ezyang gchanan jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10 Valentine233

imported-using-ghimport

Test Plan: Imported from OSS

Reviewed By: Chillee

Differential Revision: D61418679

Pulled By: drisspg
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D61418679

Copy link
Collaborator

@YifanShenSZ YifanShenSZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome safe softmax 🎊 & thanks for the subsequent fix in executorch 🙏

@drisspg
Copy link
Contributor Author

drisspg commented Aug 19, 2024

@shoumikhin not totally sure what to do about how red executorch trunk is on this one

@facebook-github-bot facebook-github-bot merged commit 9e478e8 into pytorch:main Aug 19, 2024
7 of 40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants