Add ET_EXPERIMENTAL #4802
Merged
Add ET_EXPERIMENTAL #4802
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/4802
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit fd96f77 with merge base ee7ae68 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D61368408 |
|
This pull request was exported from Phabricator. Differential Revision: D61368408 |
dbort
added a commit
to dbort/executorch
that referenced
this pull request
Aug 20, 2024
Summary: Pull Request resolved: pytorch#4802 Define a macro to annotate experimental APIs, which can change in breaking ways between releases. For now, using the `deprecated` annotation with a message seems to be the best way to generate warnings and IDE highlighting when using experimental APIs. Differential Revision: D61368408
dbort
force-pushed
the
export-D61368408
branch
from
0ca4065 to
e728543
Compare
Summary: Pull Request resolved: pytorch#4802 Define a macro to annotate experimental APIs, which can change in breaking ways between releases. For now, using the `deprecated` annotation with a message seems to be the best way to generate warnings and IDE highlighting when using experimental APIs. Reviewed By: JacobSzwejbka Differential Revision: D61368408
|
This pull request was exported from Phabricator. Differential Revision: D61368408 |
dbort
force-pushed
the
export-D61368408
branch
from
e728543 to
fd96f77
Compare
JacobSzwejbka
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Define a macro to annotate experimental APIs, which can change in breaking ways between releases.
For now, using the
deprecatedannotation with a message seems to be the best way to generate warnings and IDE highlighting when using experimental APIs.Differential Revision: D61368408