Skip to content

typing for decorators - fx/_compatibility #4810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

aorenste
Copy link
Contributor

Summary: See #131429

Differential Revision: D61493706

Copy link

pytorch-bot bot commented Aug 20, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/4810

Note: Links to docs will display an error until the docs builds have been completed.

❌ 27 New Failures, 1 Unrelated Failure

As of commit d909564 with merge base 8471c22 (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 20, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D61493706

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D61493706

aorenste added a commit to aorenste/executorch that referenced this pull request Aug 21, 2024
Summary:
Pull Request resolved: pytorch#4810

X-link: pytorch/torchrec#2322

X-link: pytorch/pytorch#134054

See #131429

Differential Revision: D61493706
aorenste added a commit to aorenste/pytorch that referenced this pull request Aug 21, 2024
Summary:
X-link: pytorch/executorch#4810

X-link: pytorch/torchrec#2322

Pull Request resolved: pytorch#134054

See pytorch#131429

Test Plan: unit tests pass

Differential Revision: D61493706
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D61493706

aorenste added a commit to aorenste/torchrec that referenced this pull request Aug 21, 2024
Summary:
X-link: pytorch/executorch#4810

Pull Request resolved: pytorch#2322

X-link: pytorch/pytorch#134054

See #131429

Differential Revision: D61493706
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D61493706

aorenste added a commit to aorenste/executorch that referenced this pull request Aug 21, 2024
Summary:
X-link: ctrl-labs/src2#33884

Pull Request resolved: pytorch#4810

X-link: pytorch/torchrec#2322

X-link: pytorch/pytorch#134054

See #131429

Differential Revision: D61493706
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D61493706

aorenste added a commit to aorenste/executorch that referenced this pull request Aug 21, 2024
Summary:
X-link: ctrl-labs/src2#33884

Pull Request resolved: pytorch#4810

X-link: pytorch/torchrec#2322

X-link: pytorch/pytorch#134054

See #131429

Differential Revision: D61493706
@aorenste aorenste force-pushed the export-D61493706 branch 2 times, most recently from 0150adc to fda520b Compare August 22, 2024 01:39
aorenste added a commit to aorenste/executorch that referenced this pull request Aug 22, 2024
Summary:
X-link: ctrl-labs/src2#33884

Pull Request resolved: pytorch#4810

X-link: pytorch/torchrec#2322

X-link: pytorch/pytorch#134054

See #131429

Differential Revision: D61493706
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D61493706

aorenste added a commit to aorenste/torchrec that referenced this pull request Aug 22, 2024
Summary:
X-link: ctrl-labs/src2#33884

X-link: pytorch/executorch#4810

Pull Request resolved: pytorch#2322

X-link: pytorch/pytorch#134054

See #131429

Differential Revision: D61493706
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D61493706

aorenste added a commit to aorenste/executorch that referenced this pull request Aug 22, 2024
Summary:
X-link: ctrl-labs/src2#33884

Pull Request resolved: pytorch#4810

X-link: pytorch/torchrec#2322

X-link: pytorch/pytorch#134054

See #131429

Differential Revision: D61493706
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D61493706

aorenste added a commit to aorenste/executorch that referenced this pull request Aug 22, 2024
Summary:
X-link: ctrl-labs/src2#33884

Pull Request resolved: pytorch#4810

X-link: pytorch/torchrec#2322

X-link: pytorch/pytorch#134054

See #131429

Differential Revision: D61493706
aorenste added a commit to aorenste/torchrec that referenced this pull request Aug 22, 2024
Summary:
X-link: ctrl-labs/src2#33884

X-link: pytorch/executorch#4810

Pull Request resolved: pytorch#2322

X-link: pytorch/pytorch#134054

See #131429

Differential Revision: D61493706
aorenste added a commit to aorenste/pytorch that referenced this pull request Aug 22, 2024
Summary:
X-link: ctrl-labs/src2#33884

X-link: pytorch/executorch#4810

X-link: pytorch/torchrec#2322

Pull Request resolved: pytorch#134054

See pytorch#131429

Test Plan: unit tests pass

Differential Revision: D61493706
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D61493706

aorenste added a commit to aorenste/executorch that referenced this pull request Aug 22, 2024
Summary:
X-link: ctrl-labs/src2#33884

Pull Request resolved: pytorch#4810

X-link: pytorch/torchrec#2322

X-link: pytorch/pytorch#134054

See #131429

Differential Revision: D61493706
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D61493706

aorenste added a commit to aorenste/torchrec that referenced this pull request Aug 24, 2024
Summary:
X-link: ctrl-labs/src2#33884

X-link: pytorch/executorch#4810

Pull Request resolved: pytorch#2322

X-link: pytorch/pytorch#134054

See #131429

Differential Revision: D61493706
aorenste added a commit to aorenste/pytorch that referenced this pull request Aug 24, 2024
Summary:
X-link: ctrl-labs/src2#33884

X-link: pytorch/executorch#4810

X-link: pytorch/torchrec#2322

Pull Request resolved: pytorch#134054

See pytorch#131429

Test Plan: unit tests pass

Differential Revision: D61493706
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D61493706

aorenste added a commit to aorenste/executorch that referenced this pull request Aug 24, 2024
Summary:
X-link: ctrl-labs/src2#33884

Pull Request resolved: pytorch#4810

X-link: pytorch/torchrec#2322

X-link: pytorch/pytorch#134054

See #131429

Differential Revision: D61493706
aorenste added a commit to aorenste/pytorch that referenced this pull request Aug 24, 2024
Summary:
X-link: ctrl-labs/src2#33884

X-link: pytorch/executorch#4810

X-link: pytorch/torchrec#2322

Pull Request resolved: pytorch#134054

See pytorch#131429

Test Plan: unit tests pass

Differential Revision: D61493706
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D61493706

aorenste added a commit to aorenste/executorch that referenced this pull request Aug 24, 2024
Summary:
X-link: ctrl-labs/src2#33884

Pull Request resolved: pytorch#4810

X-link: pytorch/torchrec#2322

X-link: pytorch/pytorch#134054

See #131429

Reviewed By: laithsakka

Differential Revision: D61493706
aorenste added a commit to aorenste/pytorch that referenced this pull request Aug 24, 2024
Summary:
X-link: ctrl-labs/src2#33884

X-link: pytorch/executorch#4810

X-link: pytorch/torchrec#2322

Pull Request resolved: pytorch#134054

See pytorch#131429

Test Plan: unit tests pass

Reviewed By: laithsakka

Differential Revision: D61493706
aorenste added a commit to aorenste/torchrec that referenced this pull request Aug 24, 2024
Summary:
X-link: ctrl-labs/src2#33884

X-link: pytorch/executorch#4810

Pull Request resolved: pytorch#2322

X-link: pytorch/pytorch#134054

See #131429

Reviewed By: laithsakka

Differential Revision: D61493706
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D61493706

aorenste added a commit to aorenste/executorch that referenced this pull request Aug 25, 2024
Summary:
X-link: ctrl-labs/src2#33884

Pull Request resolved: pytorch#4810

X-link: pytorch/torchrec#2322

X-link: pytorch/pytorch#134054

See #131429

Reviewed By: laithsakka

Differential Revision: D61493706
aorenste added a commit to aorenste/torchrec that referenced this pull request Aug 25, 2024
Summary:
X-link: ctrl-labs/src2#33884

X-link: pytorch/executorch#4810

Pull Request resolved: pytorch#2322

X-link: pytorch/pytorch#134054

See #131429

Reviewed By: laithsakka

Differential Revision: D61493706
aorenste added a commit to aorenste/pytorch that referenced this pull request Aug 25, 2024
Summary:
X-link: ctrl-labs/src2#33884

X-link: pytorch/executorch#4810

X-link: pytorch/torchrec#2322

Pull Request resolved: pytorch#134054

See pytorch#131429

Test Plan: unit tests pass

Reviewed By: laithsakka

Differential Revision: D61493706
aorenste added a commit to aorenste/torchrec that referenced this pull request Aug 25, 2024
Summary:
X-link: ctrl-labs/src2#33884

X-link: pytorch/executorch#4810

Pull Request resolved: pytorch#2322

X-link: pytorch/pytorch#134054

See #131429

Reviewed By: laithsakka

Differential Revision: D61493706
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D61493706

aorenste added a commit to aorenste/executorch that referenced this pull request Aug 25, 2024
Summary:
X-link: ctrl-labs/src2#33884

Pull Request resolved: pytorch#4810

X-link: pytorch/torchrec#2322

X-link: pytorch/pytorch#134054

See #131429

Reviewed By: laithsakka

Differential Revision: D61493706
aorenste added a commit to aorenste/pytorch that referenced this pull request Aug 25, 2024
Summary:
X-link: ctrl-labs/src2#33884

X-link: pytorch/executorch#4810

X-link: pytorch/torchrec#2322

Pull Request resolved: pytorch#134054

See pytorch#131429

Test Plan: unit tests pass

Reviewed By: laithsakka

Differential Revision: D61493706
Summary:
X-link: ctrl-labs/src2#33884

Pull Request resolved: pytorch#4810

X-link: pytorch/torchrec#2322

X-link: pytorch/pytorch#134054

See #131429

Reviewed By: laithsakka

Differential Revision: D61493706
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D61493706

aorenste added a commit to aorenste/torchrec that referenced this pull request Aug 25, 2024
Summary:
X-link: ctrl-labs/src2#33884

X-link: pytorch/executorch#4810

Pull Request resolved: pytorch#2322

X-link: pytorch/pytorch#134054

See #131429

Reviewed By: laithsakka

Differential Revision: D61493706
aorenste added a commit to aorenste/pytorch that referenced this pull request Aug 25, 2024
Summary:
X-link: ctrl-labs/src2#33884

X-link: pytorch/executorch#4810

X-link: pytorch/torchrec#2322

Pull Request resolved: pytorch#134054

See pytorch#131429

Test Plan: unit tests pass

Reviewed By: laithsakka

Differential Revision: D61493706
@facebook-github-bot facebook-github-bot merged commit ebe9075 into pytorch:main Aug 26, 2024
7 of 38 checks passed
facebook-github-bot pushed a commit to pytorch/torchrec that referenced this pull request Aug 26, 2024
Summary:
X-link: ctrl-labs/src2#33884

X-link: pytorch/executorch#4810

Pull Request resolved: #2322

X-link: pytorch/pytorch#134054

See #131429

Reviewed By: laithsakka

Differential Revision: D61493706

fbshipit-source-id: d2b3feeff2abf8610e4e9940a1b93b5f80777dc2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants