[executorch] Propagate mul optimizations from D61504544/D61560825/D61560826 to add/sub/div #4816
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…560826 to add/sub/div These diffs only updated the optimized mul operator; make the corresponding changes to the other binary arithmetic operators. Differential Revision: [D61577411](https://our.internmc.facebook.com/intern/diff/D61577411/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/4816
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit ea22993 with merge base 35e2302 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
This was referenced Aug 20, 2024
Merged
|
This pull request was exported from Phabricator. Differential Revision: D61577411 |
swolchok
added a commit
that referenced
this pull request
Aug 21, 2024
…560826 to add/sub/div These diffs only updated the optimized mul operator; make the corresponding changes to the other binary arithmetic operators. Differential Revision: [D61577411](https://our.internmc.facebook.com/intern/diff/D61577411/) ghstack-source-id: 239053659 Pull Request resolved: #4816
swolchok
requested review from
kimishpatel,
GregoryComer and
manuelcandales
and removed request for
kimishpatel,
GregoryComer and
manuelcandales
…1560825/D61560826 to add/sub/div" These diffs only updated the optimized mul operator; make the corresponding changes to the other binary arithmetic operators. Differential Revision: [D61577411](https://our.internmc.facebook.com/intern/diff/D61577411/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D61577411 |
swolchok
added a commit
that referenced
this pull request
Aug 26, 2024
…560826 to add/sub/div Pull Request resolved: #4816 These diffs only updated the optimized mul operator; make the corresponding changes to the other binary arithmetic operators. ghstack-source-id: 239747532 @exported-using-ghexport Differential Revision: [D61577411](https://our.internmc.facebook.com/intern/diff/D61577411/)
kimishpatel
approved these changes
Aug 27, 2024
…1560825/D61560826 to add/sub/div" These diffs only updated the optimized mul operator; make the corresponding changes to the other binary arithmetic operators. Differential Revision: [D61577411](https://our.internmc.facebook.com/intern/diff/D61577411/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D61577411 |
swolchok
added a commit
that referenced
this pull request
Aug 28, 2024
…560826 to add/sub/div Pull Request resolved: #4816 These diffs only updated the optimized mul operator; make the corresponding changes to the other binary arithmetic operators. ghstack-source-id: 240122841 @exported-using-ghexport Differential Revision: [D61577411](https://our.internmc.facebook.com/intern/diff/D61577411/)
facebook-github-bot
merged commit 858e9fd
into
gh/swolchok/19/base
37 of 38 checks passed
|
@pytorchbot cherry-pick --onto main |
|
❌ 🤖 pytorchbot command failed: Try |
This was referenced Aug 29, 2024
kirklandsign
added a commit
that referenced
this pull request
Aug 29, 2024
…/sub/div (#4966) These diffs only updated the optimized mul operator; make the corresponding changes to the other binary arithmetic operators. Differential Revision: D61577411 Pull Request resolved: #4816 --------- Co-authored-by: Scott Wolchok <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
These diffs only updated the optimized mul operator; make the corresponding changes to the other binary arithmetic operators.
Differential Revision: D61577411