Summary: Make xnnpack_backend depend on executorch in the CMake map cmake_deps.toml to avoid symbol duplications when the two link together.
#488
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make xnnpack_backend depend on executorch in the CMake map `cmake_deps.toml` to avoid symbol duplications when the two link together. Created from CodeHub with https://fburl.com/edit-in-codehub Differential Revision: D49624543 fbshipit-source-id: 6a5212c63f6c2e875f6e3854e4be2938500c77f0
✅ Deploy Preview for resplendent-gnome-14e531 canceled.
|
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D49624543 |
|
This pull request has been merged in a704b2b. |
Gasoonjia
pushed a commit
that referenced
this pull request
Jul 30, 2024
Fixes pytorch/torchchat#468 and pytorch/torchchat#466. Updates named arguments to be registered on subparsers, which allows removal of the arg re-ordering code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created from CodeHub with https://fburl.com/edit-in-codehub
Differential Revision: D49624543